Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 1: Prototype-polluting function #711

Open
wants to merge 1 commit into
base: main-enterprise
Choose a base branch
from
Open

Fix code scanning alert no. 1: Prototype-polluting function #711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/mergeDeep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ class MergeDeep {
// One of the oddities is when we compare objects, we are only interested in the properties of source
// So any property in the target that is not in the source is not treated as a deletion
for (const key in source) {
// Skip prototype pollution properties
if (key === "__proto__" || key === "constructor") {
Copy link
Preview

Copilot AI Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for prototype pollution properties is correct, but it should also include 'prototype' to ensure comprehensive protection against prototype pollution attacks.

Suggested change
if (key === "__proto__" || key === "constructor") {
if (key === "__proto__" || key === "constructor" || key === "prototype") {

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
continue;
}
// Logic specific for Github
// API response includes urls for resources, or other ignorable fields; we can ignore them
if (key.indexOf('url') >= 0 || this.ignorableFields.indexOf(key) >= 0) {
Expand Down
Loading