Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial pull request for Bangla translation #3350

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Rifat-Hasan-BD
Copy link

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Add better meaning in subscribe heading
@Rifat-Hasan-BD Rifat-Hasan-BD changed the title Initial pull request for Bangla translation 2nd try Initial pull request for Bangla translation Nov 29, 2024
@Rifat-Hasan-BD
Copy link
Author

I have no idea why 1 test are keep failing all the time. Should i still work on the translation?

@Ashrafjafr

This comment was marked as spam.

@Rifat-Hasan-BD
Copy link
Author

[email protected]

What do you mean by the mail address?

@Rifat-Hasan-BD
Copy link
Author

@jmeridth As per your request i start translating everything into Bangla language. But i'm unable contact with any maintainer. It's my first contribution to a open source project. Should i continue the translation?

@Rifat-Hasan-BD
Copy link
Author

@ahpook should i continue translation?

@Dirtywaters6801

This comment was marked as spam.

@Rifat-Hasan-BD
Copy link
Author

@Dirtywaters6801 in which article or section line 745 doesn't end with signature? I can't find it. Can explain it little more?

@Dirtywaters6801

This comment was marked as spam.

@Rifat-Hasan-BD
Copy link
Author

@Dirtywaters6801 How can i fix it? I have no idea. Can you help me?

@Ashrafjafr

This comment was marked as spam.

@IsSorkar

This comment was marked as spam.

@jmeridth
Copy link
Member

jmeridth commented Dec 2, 2024

[email protected]

What do you mean by the mail address?

I've marked as spam. Author can respond but usually that is spam.

@jmeridth
Copy link
Member

jmeridth commented Dec 2, 2024

@jmeridth As per your request i start translating everything into Bangla language. But i'm unable contact with any maintainer. It's my first contribution to a open source project. Should i continue the translation?

Yes. Please continue. Your failing tests can be seen here and reasons are listed. Looks like mainly complaining about unordered lists formatting. I'll look into the 404/403s before the html proofer.

Thank you for your contribution.

looks like most of the other comments on this PR are spam. I'm marking them accordingly.

@ALANthemoor
Copy link

ALANthemoor commented Dec 2, 2024 via email

@Rifat-Hasan-BD
Copy link
Author

Rifat-Hasan-BD commented Dec 4, 2024

Yes. Please continue. Your failing tests can be seen here and reasons are listed. Looks like mainly complaining about unordered lists formatting. I'll look into the 404/403s before the html proofer.

Thank you for your contribution.

looks like most of the other comments on this PR are spam. I'm marking them accordingly.

You are welcome @jmeridth.
Do you find any solution for the faild test? or should i start again from the beginning?

@jmeridth
Copy link
Member

jmeridth commented Dec 4, 2024

@Rifat-Hasan-BD the tests are failing because it looks like the markdown lists were changed from astericks (*) to hyphens (-). They need to be changed back to asterisks.

Example change

Original file

Are you possibly using a markdown linter in your IDE that has an autosave feature and a preference for hyphens for lists?

For some reason main English "best-practices.md" file contain this bug. when i simply copy the best practice file and start translation and start a pull request i face a test was failing again and again.
@Rifat-Hasan-BD
Copy link
Author

@Rifat-Hasan-BD the tests are failing because it looks like the markdown lists were changed from astericks (*) to hyphens (-). They need to be changed back to asterisks.

Example change

Original file

Are you possibly using a markdown linter in your IDE that has an autosave feature and a preference for hyphens for lists?

@jmeridth I got it.

@Rifat-Hasan-BD
Copy link
Author

Are you possibly using a markdown linter in your IDE that has an autosave feature and a preference for hyphens for lists?

@jmeridth You are correct.

@FAKHRUL12345

This comment has been minimized.

1 similar comment
@FAKHRUL12345

This comment has been minimized.

@Rifat-Hasan-BD
Copy link
Author

Dearest hope well. I am too much sick and my small one son is suffering dengue fever long days n today i would like to see dotor.

If you consider my crucial situation at present.

And pull request to fail two times.

I am ur best wishes due to 1 sime see some donation but till now dont see 2 nd times i salute until my death due to give something. Believe me i am totally hopeless everywhere.

Please consider my crucial situation.

Sincerely yours MD FAKHRUL HOSSAIN CHOWDHURY

@jmeridth This is a spam comment

I translated 69 lines from the beginning out of 280 lines.
@ALANthemoor

This comment has been minimized.

@E-456-sya
Copy link

E-456-sya commented Dec 9, 2024 via email

@eeikaaa

This comment was marked as spam.

@eeikaaa

This comment was marked as spam.

@nthhanh526

This comment was marked as spam.

@Oleksand36
Copy link

Gh

@Oleksand36
Copy link

github/communities-oss-reviewers was requested for review as a code owner

Hide all checks

@Thanhha834
Copy link

Ekdm

@github github locked as spam and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.