C#: params modifier on collection types. #18329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/params
branch
from
78817bd to
ecced67
Compare
…e the test reports indexer access and calls to Add for list and collection creations).
…s to allow ParamsCollectionType.
michaelnebel
force-pushed
the
csharp/params
branch
from
ecced67 to
f4539f7
Compare
Contributor
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 13 out of 30 changed files in this pull request and generated 2 comments.
Files not reviewed (17)
- csharp/ql/lib/semmle/code/csharp/Callable.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/Variable.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/commons/Collections.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/dispatch/Dispatch.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/frameworks/Format.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/frameworks/System.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/frameworks/system/collections/Generic.qll: Language not supported
- csharp/ql/test/library-tests/arguments/argumentByName.expected: Language not supported
- csharp/ql/test/library-tests/arguments/argumentByParameter.expected: Language not supported
- csharp/ql/test/library-tests/arguments/argumentByParameter.ql: Language not supported
- csharp/ql/test/library-tests/arguments/argumentName.expected: Language not supported
- csharp/ql/test/library-tests/arguments/argumentType.expected: Language not supported
- csharp/ql/test/library-tests/arguments/parameterGetArguments.expected: Language not supported
- csharp/ql/test/library-tests/arguments/parameterGetArguments.ql: Language not supported
- csharp/ql/test/library-tests/dispatch/CallContext.expected: Language not supported
- csharp/ql/test/library-tests/dispatch/GetADynamicTarget.expected: Language not supported
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
| { | ||
| f10(0, 1, 2); | ||
| f10(0, [1, 2]); | ||
| f10(args: 1, o: 0); |
There was a problem hiding this comment.
The params modifier expects a List, but 1 is an int. It should be f10(args: new List { 1 }, o: 0);
Suggested change
| f10(args: 1, o: 0); | |
| f10(args: new List<int> { 1 }, o: 0); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| SinkCollectionParams(new A()); // flow | ||
| SinkCollectionParams(null, new A()); // flow | ||
| SinkCollectionParams(null, new A(), null); // flow | ||
| SinkCollectionParams([new A()]); // flow |
There was a problem hiding this comment.
The use of square brackets '[]' for collection initialization is incorrect in C#. It should be replaced with curly braces '{}'.
Suggested change
| SinkCollectionParams([new A()]); // flow | |
| SinkCollectionParams(new A[] { new A() }); // flow |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we make the relevant updates to the CodeQL library to support collection like types for
paramsparameters. The extractor worked out of the box for extracting these types.The feature is described here: https://learn.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-13#params-collections