Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C++ analysis in separate workflow #16071

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

calumgrant
Copy link
Contributor

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, personally I don't have a preference with respect to the other approach, but I guess a separate workflow is preferable.

@calumgrant calumgrant marked this pull request as ready for review March 28, 2024 16:53
@calumgrant calumgrant requested a review from a team as a code owner March 28, 2024 16:53
@calumgrant calumgrant merged commit ef2e2e4 into main Mar 28, 2024
7 checks passed
@calumgrant calumgrant deleted the calumgrant/cpp-analysis branch March 28, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants