Fixed bug where some predicates were flagged without return type even…

… thought they had
github · Nov 29, 2024 · 7c1aa84 · 7c1aa84
1 parent a462ec9
commit 7c1aa84
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/ql/ql/src/queries/style/ValidatePredicateGetReturns.ql b/ql/ql/src/queries/style/ValidatePredicateGetReturns.ql
@@ -21,7 +21,7 @@ predicate isGetPredicate(Predicate pred) { pred.getName().regexpMatch("(get|as)[
 /**
  * Checks if a predicate has a return type.
  */
-predicate hasReturnType(Predicate pred) { exists(pred.getReturnType()) }
+predicate hasReturnType(Predicate pred) { exists(pred.getReturnTypeExpr()) }
 
 /**
  * Checks if a predicate is an alias using getAlias().

diff --git a/ql/ql/test/queries/style/ValidatePredicateGetReturns/test.qll b/ql/ql/test/queries/style/ValidatePredicateGetReturns/test.qll
@@ -35,3 +35,8 @@ predicate assessment() { none() }
 
 // OK -- starts with as and returns a value
 string asString() { result = "string" }
+
+// OK -- starts with get and returns a value
+HiddenType getInjectableCompositeActionNode() {
+  exists(HiddenType hidden | result = hidden.toString())
+}