Implement most MISRA-C amendment4 rule amendments

[MichaelRFairhurst]

Description

Implement most MISRA-C amendment 4 rule amendments

Change request type

• Release or process automation (GitHub workflows, internal scripts)
• Internal documentation
• External documentation
• Query files (.ql, .qll, .qls or unit tests)
• External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

• No rules added
• Queries have been added for the following rules:
  • RULE-13-2
• Queries have been modified for the following rules:
  • RULE-11-3
  • RULE-11-8
  • EXP33-C, RULE-9-1, A8-5-0, EXP53-CPP
  • RULE-3-1

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

• The structure or layout of the release artifacts.
• The evaluation performance (memory, execution time) of an existing query.
• The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

• Yes
• No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

• Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

• Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with the style guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)

Reviewer

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with the style guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)

Copilot reviewed 3 out of 22 changed files in this pull request and generated no comments.

Files not reviewed (19)

• amendments.csv: Language not supported
• c/common/test/includes/standard-library/stdatomic.h: Language not supported
• c/common/test/rules/readofuninitializedmemory/test.c: Language not supported
• c/misra/src/rules/RULE-11-3/CastBetweenObjectPointerAndDifferentObjectType.ql: Language not supported
• c/misra/src/rules/RULE-11-8/CastRemovesConstOrVolatileQualification.ql: Language not supported
• c/misra/src/rules/RULE-13-2/UnsequencedAtomicReads.ql: Language not supported
• c/misra/src/rules/RULE-3-1/CharacterSequencesAndUsedWithinAComment.ql: Language not supported
• c/misra/test/rules/RULE-11-3/CastBetweenObjectPointerAndDifferentObjectType.expected: Language not supported
• c/misra/test/rules/RULE-11-3/test.c: Language not supported
• c/misra/test/rules/RULE-11-8/CastRemovesConstOrVolatileQualification.expected: Language not supported
• c/misra/test/rules/RULE-11-8/test.c: Language not supported
• c/misra/test/rules/RULE-13-2/UnsequencedAtomicReads.expected: Language not supported
• c/misra/test/rules/RULE-13-2/UnsequencedAtomicReads.qlref: Language not supported
• c/misra/test/rules/RULE-13-2/UnsequencedSideEffects.expected: Language not supported
• c/misra/test/rules/RULE-13-2/test.c: Language not supported
• c/misra/test/rules/RULE-3-1/CharacterSequencesAndUsedWithinAComment.expected: Language not supported
• c/misra/test/rules/RULE-3-1/test.c: Language not supported
• cpp/common/src/codingstandards/cpp/exclusions/c/SideEffects3.qll: Language not supported
• cpp/common/src/codingstandards/cpp/rules/readofuninitializedmemory/ReadOfUninitializedMemory.qll: Language not supported

Comments suppressed due to low confidence (1)

change_notes/2024-12-13-implement-misra-c-amendment4-rule-amendments.md:5

• The rule EXP53-CPP is mentioned twice in the list. Ensure that each rule is listed only once.

 - `EXP33-C`, `RULE-9-1`, `A8-5-0`, `EXP53-CPP` - `DoNotReadUninitializedMemory.ql`, `ObjectWithAutoStorageDurationReadBeforeInit.ql`, `MemoryNotInitializedBeforeItIsRead.ql`, `DoNotReadUninitializedMemory.ql`

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more