Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cargo.nix generated by crate2nix #7098

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flashgnash
Copy link

@flashgnash flashgnash commented Oct 21, 2024

Cargo.nix is the name of a file generated by crate2nix from cargo.toml and cargo.lock which dwarfs all other files in smaller projects, heavily skewing language percentage readouts

(it is effectively just a nix-ified version of cargo.lock)

Add crate2nix generated file "Cargo.nix"

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

I am unsure what test changes would be neccesary, as I have added a single glob

Cargo.nix is the name of a file generated by crate2nix from cargo.toml and cargo.lock which dwarfs all other files in smaller projects, heavily skewing language percentage readouts

(it is effectively just a nix-ified version of cargo.lock)
@flashgnash flashgnash requested a review from a team as a code owner October 21, 2024 12:52
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're wanting the file to be marked as generated, you should add it to the generated.rb file, not the vendor.yml file.

You need to add a test too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants