state-res: fix allow knock -> leave on same state_key and sender

Signed-off-by: strawberry <[email protected]>
girlbossceo · Nov 21, 2024 · 97e2fb6 · 97e2fb6
1 parent d1f6357
commit 97e2fb6
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/crates/ruma-state-res/src/event_auth.rs b/crates/ruma-state-res/src/event_auth.rs
@@ -659,9 +659,14 @@ fn valid_membership_change(
         MembershipState::Leave => {
             if sender == target_user {
                 let allow = target_user_current_membership == MembershipState::Join
-                    || target_user_current_membership == MembershipState::Invite;
+                    || target_user_current_membership == MembershipState::Invite
+                    || target_user_current_membership == MembershipState::Knock;
                 if !allow {
-                    warn!(?target_user_membership_event_id, "Can't leave if not invited or joined");
+                    warn!(
+                        ?target_user_membership_event_id,
+                        ?target_user_current_membership,
+                        "Can't leave if sender is not already invited, knocked, or joined"
+                    );
                 }
                 allow
             } else if !sender_is_joined