Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password reset template, fix #199 #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SG5
Copy link

@SG5 SG5 commented Oct 7, 2021

No description provided.

@gigili
Copy link
Owner

gigili commented Oct 7, 2021

Thank you for the pr, I've left you a comment regarding the changes you made, so if you could take a look at those

@SG5
Copy link
Author

SG5 commented Oct 8, 2021

@gigili I can't find any comment. Could you help me, where have you left it?

@gigili
Copy link
Owner

gigili commented Oct 8, 2021

I've left it as part of the review comments on this pr
IMG_20211008_211251

@SG5
Copy link
Author

SG5 commented Oct 16, 2021

@gigili I can see on the screenshot, your comments still in pending. I can't see them until you submit the code review

'emailPreview' => strip_tags($emailBody),
'emailConfirmText' => 'Reset password',
'emailActivationLink' => $activationLink,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This emalActivationLink should be replaced with the name passwordResetCode both here in the model file but also as a variable name in the email template html file as well.

Also maybe a new variable should be introduced, where the passwordResetCode would be used only to show the code below the button and than have a new one called passwordResetLink which would be used as a link on the button itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants