Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template and Pydantic to v2 (GSI-465) #58

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

Cito
Copy link
Member

@Cito Cito commented Nov 13, 2023

No description provided.

@coveralls
Copy link

coveralls commented Nov 13, 2023

Pull Request Test Coverage Report for Build 6876675389

  • 32 of 33 (96.97%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 90.661%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/auth_service/user_management/claims_repository/models/dto.py 17 18 94.44%
Totals Coverage Status
Change from base Build 6563373348: -0.09%
Covered Lines: 864
Relevant Lines: 953

💛 - Coveralls

@Cito Cito requested a review from KerstenBreuer November 13, 2023 17:06
KerstenBreuer
KerstenBreuer previously approved these changes Nov 15, 2023
Copy link
Contributor

@KerstenBreuer KerstenBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sound to me

@Cito Cito merged commit ddff8ff into main Nov 15, 2023
6 checks passed
@Cito Cito deleted the update-from-template-GSI-465 branch November 15, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants