Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass correlation ID in auth adapter #108

Closed
wants to merge 5 commits into from
Closed

Conversation

Cito
Copy link
Member

@Cito Cito commented Dec 10, 2024

Not to self: This should be adapted. Instead of putting the correlation ID into the response manually, rely on the middleware that will be soon provided in the service-commons lib.

@coveralls
Copy link

coveralls commented Dec 10, 2024

Pull Request Test Coverage Report for Build 12260023772

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.333%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/auth_service/main.py 2 3 66.67%
Totals Coverage Status
Change from base Build 12159794988: 0.02%
Covered Lines: 1968
Relevant Lines: 2203

💛 - Coveralls

@Cito Cito requested a review from TheByronHimes December 10, 2024 15:53
@Cito Cito removed the request for review from TheByronHimes December 10, 2024 17:04
@Cito Cito marked this pull request as draft December 10, 2024 17:04
@Cito
Copy link
Member Author

Cito commented Dec 12, 2024

Closed in favor of #109 which makes use of the feature being provided by the service commons now.

@Cito Cito closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants