-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update template #106
Update template #106
Conversation
Pull Request Test Coverage Report for Build 12159621476Details
💛 - Coveralls |
@Cito mypy complains about the HttpUrl fields in Config. These might be reverted, and instead the mypy could be supressed here with an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, can you revert that last config change?
I suggest instead you just ignore the mypy error or wrap the default value into HttpUrl, like
organization_url: HttpUrl = Field(
default=HttpUrl("https://ghga.de")
Also, in test_totp
it should be AnyHttpUrl
instead of AnyUrl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you.
This PR updates microservice template and some dependencies. Also some code has been updated accrodingly.