Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template #106

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Update template #106

merged 9 commits into from
Dec 4, 2024

Conversation

dontseyit
Copy link
Member

@dontseyit dontseyit commented Dec 4, 2024

This PR updates microservice template and some dependencies. Also some code has been updated accrodingly.

@Cito Cito self-requested a review December 4, 2024 08:23
@coveralls
Copy link

coveralls commented Dec 4, 2024

Pull Request Test Coverage Report for Build 12159621476

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.313%

Totals Coverage Status
Change from base Build 11457974957: 0.0%
Covered Lines: 1964
Relevant Lines: 2199

💛 - Coveralls

@dontseyit
Copy link
Member Author

dontseyit commented Dec 4, 2024

@Cito mypy complains about the HttpUrl fields in Config. Incompatible types in assignment (expression has type "str", variable has type "HttpUrl") My solution without losing the URL validation is to replace them with str type but using the field_validator for URL validation. This caused some cascading updates 5495868. This change also caused some config schema changes. f3e4665

These might be reverted, and instead the mypy could be supressed here with an ignore comment

Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, can you revert that last config change?

I suggest instead you just ignore the mypy error or wrap the default value into HttpUrl, like

    organization_url: HttpUrl = Field(
        default=HttpUrl("https://ghga.de")

Also, in test_totp it should be AnyHttpUrl instead of AnyUrl.

@dontseyit dontseyit requested a review from Cito December 4, 2024 12:25
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@dontseyit dontseyit merged commit afbeb5f into main Dec 4, 2024
9 checks passed
@dontseyit dontseyit deleted the feature/update-template branch December 4, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants