Skip to content

Commit

Permalink
improve method signature
Browse files Browse the repository at this point in the history
  • Loading branch information
Full Name committed May 16, 2024
1 parent d767095 commit 6b2f3ea
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:
pull-requests: write

env:
PLUGIN_JSON: "2.0.0"
PLUGIN_JSON: "1.2.0"
TAG_EXISTS: false
PLUGIN_NAME: "aws-integration"

Expand Down
5 changes: 3 additions & 2 deletions aws_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,9 @@ class AWSSettings(BaseModel):
)

@classmethod
def get_aws(cls, settings) -> Optional[Boto3Builder]:
def get_aws(cls, settings, service_name=None) -> Optional[Boto3Builder]:
return Boto3Builder(
service_name=service_name,
profile_name=settings.get("credentials_profile_name"),
aws_access_key_id=settings.get("aws_access_key_id"),
aws_secret_access_key=settings.get("aws_secret_access_key"),
Expand Down Expand Up @@ -127,7 +128,7 @@ def validate(cls, v):
if not v.credentials_profile_name:
if not v.aws_access_key_id or not v.aws_secret_access_key:
raise ValueError(
"Either provide a credentials profile name or both aws_access_key_id and aws_secret_access_key"
"Enable the IAM role or provide a credentials profile name or both aws_access_key_id and aws_secret_access_key."
)
elif not (
len(v.aws_access_key_id) == AWS_ACCES_KEY_LEN
Expand Down
2 changes: 1 addition & 1 deletion plugin.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "AWS Client Configuration Manager",
"version": "2.0.0",
"version": "1.2.0",
"description": "This plugin provides a robust and secure way to manage AWS client configurations. It ensures that AWS credentials and region settings are correct.",
"author_name": "Gianluigi Mucciolo",
"author_url": "https://www.linkedin.com/in/ggiallo28/",
Expand Down

0 comments on commit 6b2f3ea

Please sign in to comment.