Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make unpack4x{I,U}8 output exprs. composable in {hlsl,msl}-out #6773

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

fix: make unpack4x{I,U}8 output exprs. composable in {hlsl,msl}-out #6773

wants to merge 2 commits into from

Conversation

ErichDonGubler
Copy link
Member

Fixes #6772.

@ErichDonGubler ErichDonGubler self-assigned this Dec 17, 2024
@ErichDonGubler ErichDonGubler added type: bug Something isn't working api: metal Issues with Metal naga Shader Translator area: naga back-end Outputs of naga shader conversion labels Dec 17, 2024
@ErichDonGubler ErichDonGubler added api: dx12 Issues with DX12 or DXGI lang: HLSL D3D Shading Language lang: Metal Metal Shading Language labels Dec 17, 2024
@ErichDonGubler ErichDonGubler changed the title fix(msl-out): make unpack4x{I,U}8 output exprs. composable fix: make unpack4x{I,U}8 output exprs. composable in {hlsl,msl}-out Dec 17, 2024
@ErichDonGubler ErichDonGubler marked this pull request as ready for review December 17, 2024 20:44
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner December 17, 2024 20:44
@ErichDonGubler ErichDonGubler enabled auto-merge (squash) December 17, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimblandy jimblandy

Labels
api: dx12 Issues with DX12 or DXGI api: metal Issues with Metal area: naga back-end Outputs of naga shader conversion lang: HLSL D3D Shading Language lang: Metal Metal Shading Language naga Shader Translator type: bug Something isn't working
Projects
WebGPU for Firefox
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accesses of expressions emitted by unpack4x{I,U}8 in {hlsl,msl}-out cause compilation errors
2 participants
@ErichDonGubler @jimblandy