Add DeviceRef::new_texture_with_descriptor_and_iosurface #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The comment and link in your description are wrong, those are already there. In this PR you're adding: https://developer.apple.com/documentation/metal/mtldevice/1433378-newtexturewithdescriptor with signature: And the title should describe that you're adding the constructor, not the texture itself. |
fabiosky
changed the title
DeviceRef::new_texture_with_descriptor_and_iosurface
fabiosky
changed the title
DeviceRef::new_texture_with_descriptor_and_iosurface
|
Renamed commit message and PR title/message. |
MarijnS95
reviewed
Jul 29, 2024
kvark
reviewed
Nov 24, 2024
| @@ -35,6 +35,7 @@ block = "0.1.6" | |||
| foreign-types = "0.5" | |||
| dispatch = { version = "0.2", optional = true } | |||
| paste = "1" | |||
| io-surface = { git = "https://github.com/servo/core-foundation-rs" } | |||
There was a problem hiding this comment.
not that this is a rather confusing dependency. Ideally, it matches the crate name
|
Also, ideally IOSurface is included in core-foundation-types... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
DeviceRef::new_texture_with_descriptor_and_iosurfaceIOSurfaceRef is already defined in:
https://github.com/servo/core-foundation-rs/tree/main/io-surface
So importing as dependency.