Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating default open ai model in config and tests #354

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

bricemacias
Copy link
Contributor

@bricemacias bricemacias commented Aug 13, 2024

changing default openai model in config an tests from 3.5-turbo to 4o-mini


🚀 This description was created by Ellipsis for commit 05d4ef4

Summary:

The PR updates the default OpenAI model to gpt-4o-mini in configuration and test files, affecting various tests and configurations.

Key points:

  • Updated model in config.yaml from gpt-3.5-turbo-1106 to gpt-4o-mini.
  • Modified pkg/llms/llm_openai_test.go to use gpt-4o-mini in TestZepOpenAILLM_Init, TestZepOpenAILLM_Call.
  • Changed pkg/tasks/message_intent_analysis_test.go to use gpt-4o-mini in TestIntentExtractor_Extract_OpenAI.
  • Updated pkg/tasks/message_summarizer_test.go to use gpt-4o-mini in TestSummarize_OpenAI.
  • Modified pkg/tasks/message_token_counter_test.go to use gpt-4o-mini in TestTokenCountExtractor_OpenAI.
  • Updated pkg/testutils/utils.go to set default model to gpt-4o-mini in testConfigDefaults.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 05d4ef4 in 20 seconds

More details
  • Looked at 104 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. config.yaml:5
  • Draft comment:
    The update from gpt-3.5-turbo to gpt-4o-mini is correctly reflected here, aligning with the PR's intent.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description indicates that the default model is being updated from gpt-3.5-turbo to gpt-4o-mini in the configuration and tests. The changes in the PR reflect this update consistently across the configuration file and all test files. Each test file that previously used gpt-3.5-turbo or a variant now uses gpt-4o-mini. This is a straightforward update with no additional logic changes or complex modifications. The PR seems to be correctly implementing the intended changes as described.

Workflow ID: wflow_f9fk7hjYEXuTJqfs


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit 60a3a11 into getzep:main Aug 14, 2024
1 of 2 checks passed
@paul-paliychuk
Copy link
Collaborator

@bricemacias lgtm thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants