-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix manual image release workflow #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-paliychuk
temporarily deployed
to
development
September 6, 2024 16:29 — with
GitHub Actions
Inactive
paul-paliychuk
temporarily deployed
to
development
September 6, 2024 16:29 — with
GitHub Actions
Inactive
paul-paliychuk
temporarily deployed
to
development
September 6, 2024 16:29 — with
GitHub Actions
Inactive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to a7466a9 in 40 seconds
More details
- Looked at
38
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. .github/workflows/release-service-image.yml:49
- Draft comment:
github.ref_name
is not a valid context. Usegithub.ref
instead. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is about a change made in the diff, specifically the use of 'github.ref_name'. The comment claims that 'github.ref_name' is not valid, which would be a clear code issue if true. I need to verify if 'github.ref_name' is indeed invalid in GitHub Actions context.
I might be missing the latest updates or changes in GitHub Actions context names. It's possible that 'github.ref_name' is valid in newer versions.
I should verify the validity of 'github.ref_name' in the context of GitHub Actions to ensure the comment is accurate.
Check if 'github.ref_name' is a valid context in GitHub Actions. If it is not valid, keep the comment; otherwise, delete it.
Workflow ID: wflow_JJBFVWsWPRfsWAMo
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes image release workflow by extracting version from tags and updating Docker metadata handling in
.github/workflows/release-service-image.yml
.Key points:
.github/workflows/release-service-image.yml
to fix image release workflow.Extract version from tag
step to parse version, major, and minor from tag.Extract Docker metadata
step to use parsed version information.workflow_dispatch
event to optionally push aslatest
ifpush_as_latest
is true.Generated with ❤️ by ellipsis.dev