Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual image release workflow #91

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

paul-paliychuk
Copy link
Collaborator

@paul-paliychuk paul-paliychuk commented Sep 6, 2024

🚀 This description was created by Ellipsis for commit a7466a9

Summary:

Fixes image release workflow by extracting version from tags and updating Docker metadata handling in .github/workflows/release-service-image.yml.

Key points:

  • Updates .github/workflows/release-service-image.yml to fix image release workflow.
  • Adds Extract version from tag step to parse version, major, and minor from tag.
  • Modifies Extract Docker metadata step to use parsed version information.
  • Handles workflow_dispatch event to optionally push as latest if push_as_latest is true.
  • Ensures tags are correctly set for Docker images based on version information.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a7466a9 in 40 seconds

More details
  • Looked at 38 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/release-service-image.yml:49
  • Draft comment:
    github.ref_name is not a valid context. Use github.ref instead.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is about a change made in the diff, specifically the use of 'github.ref_name'. The comment claims that 'github.ref_name' is not valid, which would be a clear code issue if true. I need to verify if 'github.ref_name' is indeed invalid in GitHub Actions context.
    I might be missing the latest updates or changes in GitHub Actions context names. It's possible that 'github.ref_name' is valid in newer versions.
    I should verify the validity of 'github.ref_name' in the context of GitHub Actions to ensure the comment is accurate.
    Check if 'github.ref_name' is a valid context in GitHub Actions. If it is not valid, keep the comment; otherwise, delete it.

Workflow ID: wflow_JJBFVWsWPRfsWAMo


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit c7fc057 into main Sep 6, 2024
7 checks passed
@paul-paliychuk paul-paliychuk deleted the fix-manual-image-release-workflow branch September 6, 2024 16:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant