Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apache License 2.0 boilerplate to all Python files #30

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

danielchalef
Copy link
Member

@danielchalef danielchalef commented Aug 23, 2024


For more details, open the Copilot Workspace session.


🚀 This description was created by Ellipsis for commit be83f5a

Summary:

Added Apache License 2.0 boilerplate to Python files and introduced ellipsis.yaml for PR review configuration.

Key points:

  • Added Apache License 2.0 boilerplate to all Python files.
  • Affected directories: core, examples, core/utils, core/prompts.
  • License text added as a multi-line comment at the top of each file.
  • Introduced ellipsis.yaml for PR review configuration.
  • No functional changes to the code, only comments added.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d22d768 in 14 seconds

More details
  • Looked at 534 lines of code in 21 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. core/prompts/lib.py:100
  • Draft comment:
    Missing closing parenthesis in the comment.
            setattr(self, prompt_type, PromptTypeWrapper(versions))  # type: ignore[arg-type]
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The license header is correctly added to all files. However, there is a missing closing parenthesis in a comment in core/prompts/lib.py. This is a minor issue but should be corrected for consistency and to avoid confusion.

Workflow ID: wflow_eczhwiomCGS27fZ5


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 4f2e1d7 in 20 seconds

More details
  • Looked at 442 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. core/utils/bulk_utils.py:31
  • Draft comment:
    The indentation in this file has been changed from spaces to tabs. This change is not mentioned in the PR description and is unrelated to the addition of the Apache License 2.0 boilerplate. Please ensure that the indentation style is consistent with the rest of the codebase.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_gARjUelzu3OcU6wl


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

core/prompts/dedupe_edges.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 4e77a21 in 15 seconds

More details
  • Looked at 458 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. core/prompts/dedupe_edges.py:23
  • Draft comment:
    Inconsistent indentation: spaces are used instead of tabs. Ensure consistent use of spaces or tabs throughout the file for better readability and adherence to style guidelines.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The license text is correctly added as a multi-line comment at the top of the file. However, the indentation in the rest of the file is inconsistent, with spaces used instead of tabs. This should be corrected for consistency and adherence to Python's style guidelines.
2. core/utils/bulk_utils.py:46
  • Draft comment:
    Inconsistent indentation: spaces are used instead of tabs. Ensure consistent use of spaces or tabs throughout the file for better readability and adherence to style guidelines.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The license text is correctly added as a multi-line comment at the top of the file. However, the indentation in the rest of the file is inconsistent, with spaces used instead of tabs. This should be corrected for consistency and adherence to Python's style guidelines.

Workflow ID: wflow_DXj5uZmHJlCjQBpQ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on be83f5a in 13 seconds

More details
  • Looked at 28 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. ellipsis.yaml:20
  • Draft comment:
    Add a newline at the end of the file for better compatibility with UNIX tools and to follow best practices.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The YAML file is missing a newline at the end, which is a best practice for text files.
2. ellipsis.yaml:20
  • Draft comment:
    Add a newline at the end of the file for consistency with common coding standards.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The file is missing a newline at the end, which is a common convention in many coding standards.

Workflow ID: wflow_UNHTeMjgPSypUFnl


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit 6d52be4 into main Aug 23, 2024
5 checks passed
@paul-paliychuk paul-paliychuk deleted the danielchalef/add-license branch August 23, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants