-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add real world dates extraction #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 07950b2 in 27 seconds
More details
- Looked at
319
lines of code in6
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. runner.py:98
- Draft comment:
Remove commented-out code to keep the codebase clean and maintainable. - Reason this comment was not posted:
Confidence changes required:50%
The code inrunner.py
contains commented-out sections that are not used. These should be removed to keep the code clean and maintainable.
2. core/utils/maintenance/temporal_operations.py:154
- Draft comment:
Consider handlingValueError
fordatetime.fromisoformat
to avoid runtime errors if the format is incorrect. - Reason this comment was not posted:
Marked as duplicate.
3. core/graphiti.py:176
- Draft comment:
Remove the redundant log statement for extracted nodes. - Reason this comment was not posted:
Confidence changes required:50%
Ingraphiti.py
, theadd_episode
method logs extracted nodes twice, which is redundant. The second log statement should be removed. This is a general comment and not specific to the diff lines.
Workflow ID: wflow_p3rLl5uXazBbyqFp
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 9809179 in 14 seconds
More details
- Looked at
35
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. core/utils/maintenance/temporal_operations.py:145
- Draft comment:
Consider usingList
fromtyping
for type hints instead oflist
for consistency. This applies to other similar instances in the file. - Reason this comment was not posted:
Confidence changes required:50%
The code useslist
instead ofList
fromtyping
for type hints, which is inconsistent and can be confusing.
Workflow ID: wflow_d2sPGacCKVhwAgxp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on e73c955 in 16 seconds
More details
- Looked at
45
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_r28HClGkt0NZS4gj
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 5608bad in 20 seconds
More details
- Looked at
442
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. core/utils/bulk_utils.py:15
- Draft comment:
Inconsistent indentation: The file uses tabs instead of spaces. Consider using spaces for consistent indentation across the codebase. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_zeZDx0DOxNsFaGrn
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on f0c98d0 in 31 seconds
More details
- Looked at
5652
lines of code in31
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. pyproject.toml:61
- Draft comment:
The change from tab to space indentation aligns with the code style in the modified files, ensuring consistency across the project. - Reason this comment was not posted:
Confidence changes required:0%
The change from tab to space indentation in the pyproject.toml file is consistent with the code style in the modified files, which use spaces for indentation. This change ensures consistency across the project.
Workflow ID: wflow_k5ea8r4E07eNdeTn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary:
This PR adds functionality to extract and assign real-world dates to graph edges using LLM, updating several files to integrate this feature.
Key points:
extract_edge_dates.py
incore/prompts
for date extraction prompts.core/graphiti.py
to useextract_edge_dates
inadd_episode
for edge date assignment.core/prompts/lib.py
to includeextract_edge_dates
.extract_edge_dates
incore/utils/maintenance/temporal_operations.py
using LLM.core/prompts/extract_nodes.py
to handle temporal info via edges.runner.py
with test cases for date extraction.Generated with ❤️ by ellipsis.dev