Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add real world dates extraction #26

Merged
merged 9 commits into from
Aug 23, 2024
Merged

feat: Add real world dates extraction #26

merged 9 commits into from
Aug 23, 2024

Conversation

paul-paliychuk
Copy link
Collaborator

@paul-paliychuk paul-paliychuk commented Aug 23, 2024

🚀 This description was created by Ellipsis for commit f0c98d0

Summary:

This PR adds functionality to extract and assign real-world dates to graph edges using LLM, updating several files to integrate this feature.

Key points:

  • Adds functionality to extract and assign real-world dates to graph edges using LLM.
  • Introduces extract_edge_dates.py in core/prompts for date extraction prompts.
  • Updates core/graphiti.py to use extract_edge_dates in add_episode for edge date assignment.
  • Modifies core/prompts/lib.py to include extract_edge_dates.
  • Implements extract_edge_dates in core/utils/maintenance/temporal_operations.py using LLM.
  • Adjusts core/prompts/extract_nodes.py to handle temporal info via edges.
  • Updates runner.py with test cases for date extraction.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 07950b2 in 27 seconds

More details
  • Looked at 319 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. runner.py:98
  • Draft comment:
    Remove commented-out code to keep the codebase clean and maintainable.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code in runner.py contains commented-out sections that are not used. These should be removed to keep the code clean and maintainable.
2. core/utils/maintenance/temporal_operations.py:154
  • Draft comment:
    Consider handling ValueError for datetime.fromisoformat to avoid runtime errors if the format is incorrect.
  • Reason this comment was not posted:
    Marked as duplicate.
3. core/graphiti.py:176
  • Draft comment:
    Remove the redundant log statement for extracted nodes.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    In graphiti.py, the add_episode method logs extracted nodes twice, which is redundant. The second log statement should be removed. This is a general comment and not specific to the diff lines.

Workflow ID: wflow_p3rLl5uXazBbyqFp


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

core/utils/maintenance/temporal_operations.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 9809179 in 14 seconds

More details
  • Looked at 35 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. core/utils/maintenance/temporal_operations.py:145
  • Draft comment:
    Consider using List from typing for type hints instead of list for consistency. This applies to other similar instances in the file.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code uses list instead of List from typing for type hints, which is inconsistent and can be confusing.

Workflow ID: wflow_d2sPGacCKVhwAgxp


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on e73c955 in 16 seconds

More details
  • Looked at 45 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_r28HClGkt0NZS4gj


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

runner.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 5608bad in 20 seconds

More details
  • Looked at 442 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. core/utils/bulk_utils.py:15
  • Draft comment:
    Inconsistent indentation: The file uses tabs instead of spaces. Consider using spaces for consistent indentation across the codebase.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_zeZDx0DOxNsFaGrn


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

core/prompts/dedupe_edges.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on f0c98d0 in 31 seconds

More details
  • Looked at 5652 lines of code in 31 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pyproject.toml:61
  • Draft comment:
    The change from tab to space indentation aligns with the code style in the modified files, ensuring consistency across the project.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change from tab to space indentation in the pyproject.toml file is consistent with the code style in the modified files, which use spaces for indentation. This change ensures consistency across the project.

Workflow ID: wflow_k5ea8r4E07eNdeTn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@prasmussen15 prasmussen15 merged commit 605219f into main Aug 23, 2024
5 checks passed
@prasmussen15 prasmussen15 deleted the extract-dates branch August 23, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants