default to no pagination

[prasmussen15]

Important

Set default pagination limit to None in get_by_group_ids methods in edges.py and nodes.py, removing default query limits.

• Behavior:
  • Default pagination limit set to None in get_by_group_ids methods in edges.py and nodes.py.
  • Queries now include LIMIT $limit only if limit is specified.
• Functions:
  • Updated get_by_group_ids in EpisodicEdge, EntityEdge, CommunityEdge in edges.py.
  • Updated get_by_group_ids in EpisodicNode, EntityNode, CommunityNode in nodes.py.
• Misc:
  • Removed DEFAULT_PAGE_LIMIT import from edges.py and nodes.py.

^{This description was created by for fd729bc. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 63e7511 in 34 seconds

More details

• Looked at 153 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. graphiti_core/edges.py:166

• Draft comment:
  Using string concatenation to build SQL queries can lead to SQL injection vulnerabilities. Consider using parameterized queries or a query builder to safely construct queries. This issue is also present in other similar methods in this file and in graphiti_core/nodes.py.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. graphiti_core/edges.py:142

• Draft comment:
  The logic for handling 'limit' and 'created_at' parameters in the 'get_by_group_ids' method is repeated across multiple classes. Consider refactoring this into a shared utility function to adhere to the DRY principle. This is also applicable in other similar methods in this file and in nodes.py.
• Reason this comment was not posted:
  Confidence changes required: 80%
  The code has multiple instances of similar logic for handling the 'limit' and 'created_at' parameters in the 'get_by_group_ids' methods across different classes. This violates the DRY principle.

3. graphiti_core/nodes.py:212

• Draft comment:
  The logic for handling 'limit' and 'created_at' parameters in the 'get_by_group_ids' method is repeated across multiple classes. Consider refactoring this into a shared utility function to adhere to the DRY principle. This is also applicable in other similar methods in this file and in edges.py.
• Reason this comment was not posted:
  Confidence changes required: 80%
  The code has multiple instances of similar logic for handling the 'limit' and 'created_at' parameters in the 'get_by_group_ids' methods across different classes. This violates the DRY principle.

Workflow ID: wflow_5M9bJdY7ppA4g7aU

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on fd729bc in 15 seconds

More details

• Looked at 27 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. graphiti_core/edges.py:30

• Draft comment:
  Unused import DEFAULT_PAGE_LIMIT removed. Ensure that this change is consistent with the intended behavior of removing default query limits.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The PR description indicates that the default pagination limit is set to None in get_by_group_ids methods across edges.py and nodes.py. The import of DEFAULT_PAGE_LIMIT is removed, which is consistent with this change.

2. graphiti_core/nodes.py:31

• Draft comment:
  Unused import DEFAULT_PAGE_LIMIT removed. Ensure that this change is consistent with the intended behavior of removing default query limits.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The PR description indicates that the default pagination limit is set to None in get_by_group_ids methods across edges.py and nodes.py. The import of DEFAULT_PAGE_LIMIT is removed, which is consistent with this change.

Workflow ID: wflow_YvfhdareV1QOImLe

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.