Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node distance reranker #231

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

prasmussen15
Copy link
Collaborator

@prasmussen15 prasmussen15 commented Dec 6, 2024

Important

Fix node_distance_reranker in search_utils.py to handle missing scores and ensure proper node sorting.

  • Behavior:
    • Fix node_distance_reranker() in search_utils.py to initialize scores with center_node_uuid and set missing scores to float('inf').
    • Ensure all node_uuids are scored, defaulting to infinity if not found.
  • Tests:
    • Add newline in test_graphiti_int.py for formatting consistency.

This description was created by Ellipsis for cb0472c. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to cb0472c in 21 seconds

More details
  • Looked at 41 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. graphiti_core/search/search_utils.py:631
  • Draft comment:
    The Cypher query uses SHORTEST 1, which is incorrect. It should be SHORTESTPATH.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.
2. tests/test_graphiti_int.py:75
  • Draft comment:
    Remove the unnecessary blank line added here to maintain code consistency and adhere to the DRY principle.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The added blank line is unnecessary and does not follow the DRY principle.

Workflow ID: wflow_jbZhjbSje1ih8i4B


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@prasmussen15 prasmussen15 merged commit 6a152ab into main Dec 6, 2024
7 checks passed
@prasmussen15 prasmussen15 deleted the fix-node-distance-reranking branch December 6, 2024 17:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants