Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search recipes #210

Merged
merged 1 commit into from
Nov 6, 2024
Merged

add search recipes #210

merged 1 commit into from
Nov 6, 2024

Conversation

prasmussen15
Copy link
Collaborator

@prasmussen15 prasmussen15 commented Nov 6, 2024

Important

Add new hybrid search configurations with cross encoder reranking for edges, nodes, and communities in search_config_recipes.py.

  • New Search Configurations:
    • Adds EDGE_HYBRID_SEARCH_CROSS_ENCODER to perform hybrid search over edges with cross encoder reranking, using bm25, cosine_similarity, and bfs methods, with a limit of 10.
    • Adds NODE_HYBRID_SEARCH_CROSS_ENCODER to perform hybrid search over nodes with cross encoder reranking, using bm25, cosine_similarity, and bfs methods, with a limit of 10.
    • Adds COMMUNITY_HYBRID_SEARCH_CROSS_ENCODER to perform hybrid search over communities with cross encoder reranking, using bm25 and cosine_similarity methods, with a limit of 3.

This description was created by Ellipsis for e20450d. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e20450d in 45 seconds

More details
  • Looked at 57 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. graphiti_core/search/search_config_recipes.py:166
  • Draft comment:
    The comment should mention "cross encoder" instead of "episode mentions" for consistency and accuracy.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The comment for NODE_HYBRID_SEARCH_CROSS_ENCODER is incorrect. It mentions "episode mentions" instead of "cross encoder".
2. graphiti_core/search/search_config_recipes.py:195
  • Draft comment:
    The comment should mention "cross encoder" instead of "mmr" for consistency and accuracy.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The comment for COMMUNITY_HYBRID_SEARCH_CROSS_ENCODER is incorrect. It mentions "mmr" instead of "cross encoder".
3. graphiti_core/search/search_config_recipes.py:166
  • Draft comment:
    The comment here is incorrect. It should describe the cross encoder reranking, not episode mentions. Please update it to accurately reflect the functionality.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The comment for NODE_HYBRID_SEARCH_CROSS_ENCODER is incorrect and duplicates the comment for NODE_HYBRID_SEARCH_EPISODE_MENTIONS. It should be corrected to reflect the actual functionality.

Workflow ID: wflow_IzaSrAZlm1faWDnU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@prasmussen15 prasmussen15 merged commit 857a8f6 into main Nov 6, 2024
7 checks passed
@prasmussen15 prasmussen15 deleted the add-recipes branch November 6, 2024 19:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant