Avoid a nasty crash if a package has a malformed version string #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheepman4267
force-pushed
the
fix-version-compare
branch
from
bbf476f to
7e1cdaa
Compare
ermo
force-pushed
the
fix-version-compare
branch
2 times, most recently
from
9a6eee4 to
e784ad5
Compare
ermo
force-pushed
the
fix-version-compare
branch
from
e784ad5 to
459d5ec
Compare
sheepman4267
commented
Dec 17, 2024
Stop mindlessly comparing version numbers that we do not care about; we exclusively care about the distribution release integer for comparisons. In addition, update information string output to reflect the above. Signed-off-by: Rune Morling <[email protected]>
ermo
force-pushed
the
fix-version-compare
branch
from
459d5ec to
ee88d43
Compare
|
@sheepman4267 Better now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 eopkg versions crash badly if a package has a malformed
versionstring, such as3.0.0d. While we don't want versions formatted like that, it shouldn't crash eopkg completely.This PR makes that case an error (to alert packagers testing it to the issue), but allows package installation to succeed.
For context, the reason that we're making this case an error is that people on older eopkg 4.x versions will still experience an eopkg crash with a cryptic error message if they encounter malformed version strings.