Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Use regex to extract URL from DSN for filtering breadcrumbs #4395

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/core/src/js/sdk.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,15 @@ export function init(passedOptions: ReactNativeOptions): void {
return undefined;
}
try {
const url = new URL(dsn);
return `${url.protocol}//${url.host}`;
const regex = /^(https?):\/\/(?:[^@]+@)?([^/]+)(?:\/.*)?$/;
const matches = dsn.match(regex);

if (matches) {
const [, protocol, host] = matches;
return `${protocol}://${host}`;
}
logger.error('Failed to extract url from DSN: ', dsn);
return undefined;
} catch (e) {
logger.error('Failed to extract url from DSN', e);
return undefined;
Expand Down
13 changes: 2 additions & 11 deletions packages/core/test/sdk.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -345,21 +345,15 @@ describe('Tests the SDK functionality', () => {
expect(result).toBeNull();
});

it('should keep breadcrumbs matching dsn if the url parsing fails for dsn', () => {
it('should keep breadcrumbs if the url parsing fails for dsn', () => {
(getDevServer as jest.Mock).mockReturnValue({ url: 'http://localhost:8081' });

const mockBeforeBreadcrumb = (breadcrumb: Breadcrumb, _hint?: BreadcrumbHint) => {
return breadcrumb;
};

// Mock the URL constructor to throw an exception for this test case
const originalURL = (global as any).URL;
jest.spyOn(global as any, 'URL').mockImplementationOnce(() => {
throw new Error('Failed to parse DSN URL');
});

const passedOptions = {
dsn: 'https://[email protected]/1234567',
dsn: 'invalid-dsn',
beforeBreadcrumb: mockBeforeBreadcrumb,
};

Expand All @@ -373,9 +367,6 @@ describe('Tests the SDK functionality', () => {
const result = usedOptions()?.beforeBreadcrumb!(breadcrumb);

expect(result).toEqual(breadcrumb);

// Restore the original URL constructor
(global as any).URL = originalURL;
});

it('should keep non dev server or dsn breadcrumbs', () => {
Expand Down
Loading