Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add RN SDK package to sdk.packages on Android #4380

Merged
merged 3 commits into from
Dec 17, 2024
Merged

feat: Add RN SDK package to sdk.packages on Android #4380

merged 3 commits into from
Dec 17, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This improves session replays metadata, as now the events will contain name and version of the RN sdk in the event.sdk.packages.

💡 Motivation and Context

This helps whe debuggin session replay in Sentry product.

💚 How did you test it?

sample app

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against bae9bf6

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 662.87 ms 646.94 ms -15.93 ms
Size 17.74 MiB 20.10 MiB 2.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
484813b 434.55 ms 452.31 ms 17.75 ms
0d3e677 422.82 ms 411.90 ms -10.92 ms
8ae23a7 526.83 ms 513.38 ms -13.45 ms
b8ff156 438.80 ms 454.14 ms 15.34 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
70e6261 482.65 ms 495.70 ms 13.05 ms
07e58c9 495.04 ms 489.73 ms -5.31 ms
6c56eb1 453.81 ms 434.83 ms -18.98 ms
e540498 436.26 ms 433.00 ms -3.26 ms

App size

Revision Plain With Sentry Diff
484813b 17.73 MiB 20.07 MiB 2.33 MiB
0d3e677 17.74 MiB 20.07 MiB 2.34 MiB
8ae23a7 17.74 MiB 20.07 MiB 2.34 MiB
b8ff156 17.74 MiB 20.09 MiB 2.35 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB
07e58c9 17.74 MiB 20.08 MiB 2.34 MiB
6c56eb1 17.74 MiB 20.09 MiB 2.35 MiB
e540498 17.73 MiB 20.11 MiB 2.37 MiB

Previous results on branch: kw/add-rn-sdk-package-for-android

Startup times

Revision Plain With Sentry Diff
769451f 465.73 ms 449.23 ms -16.50 ms

App size

Revision Plain With Sentry Diff
769451f 17.74 MiB 20.10 MiB 2.36 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 381.57 ms 419.76 ms 38.18 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5a22220+dirty 384.61 ms 419.06 ms 34.45 ms
db44eaf+dirty 394.26 ms 438.88 ms 44.62 ms
9dabcce+dirty 359.66 ms 430.73 ms 71.08 ms
e22745e+dirty 415.50 ms 448.76 ms 33.26 ms
baa882f+dirty 449.30 ms 540.40 ms 91.10 ms
0d3e677+dirty 384.24 ms 431.45 ms 47.21 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
690220d+dirty 492.10 ms 473.88 ms -18.23 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms

App size

Revision Plain With Sentry Diff
5a22220+dirty 7.15 MiB 8.21 MiB 1.06 MiB
db44eaf+dirty 7.15 MiB 8.36 MiB 1.21 MiB
9dabcce+dirty 7.15 MiB 8.37 MiB 1.22 MiB
e22745e+dirty 7.15 MiB 8.35 MiB 1.20 MiB
baa882f+dirty 7.15 MiB 8.34 MiB 1.19 MiB
0d3e677+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
690220d+dirty 7.15 MiB 8.36 MiB 1.21 MiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB

Previous results on branch: kw/add-rn-sdk-package-for-android

Startup times

Revision Plain With Sentry Diff
769451f+dirty 479.04 ms 574.37 ms 95.32 ms
bab8d22+dirty 384.85 ms 417.50 ms 32.65 ms

App size

Revision Plain With Sentry Diff
769451f+dirty 7.15 MiB 8.37 MiB 1.22 MiB
bab8d22+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.16 ms 1234.55 ms 1.39 ms
Size 2.36 MiB 3.11 MiB 760.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7f6950b+dirty 1235.53 ms 1227.30 ms -8.23 ms
31fcca2+dirty 1209.17 ms 1216.21 ms 7.04 ms
8e80789+dirty 1228.04 ms 1237.20 ms 9.16 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
a5d86e1+dirty 1242.47 ms 1239.94 ms -2.53 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
27ef4ee+dirty 1293.52 ms 1296.08 ms 2.56 ms
ddc0552+dirty 1236.13 ms 1248.17 ms 12.05 ms
8ae23a7+dirty 1230.02 ms 1227.62 ms -2.40 ms

App size

Revision Plain With Sentry Diff
7f6950b+dirty 2.36 MiB 3.11 MiB 760.04 KiB
31fcca2+dirty 2.36 MiB 2.90 MiB 552.95 KiB
8e80789+dirty 2.36 MiB 3.10 MiB 759.43 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
a5d86e1+dirty 2.36 MiB 3.10 MiB 752.65 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
27ef4ee+dirty 2.36 MiB 2.85 MiB 500.03 KiB
ddc0552+dirty 2.36 MiB 3.11 MiB 759.84 KiB
8ae23a7+dirty 2.36 MiB 3.10 MiB 752.42 KiB

Previous results on branch: kw/add-rn-sdk-package-for-android

Startup times

Revision Plain With Sentry Diff
769451f+dirty 1228.27 ms 1228.46 ms 0.19 ms
bab8d22+dirty 1222.83 ms 1233.10 ms 10.27 ms

App size

Revision Plain With Sentry Diff
769451f+dirty 2.36 MiB 3.11 MiB 760.01 KiB
bab8d22+dirty 2.36 MiB 3.11 MiB 759.93 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.61 ms 1228.31 ms 2.69 ms
Size 2.92 MiB 3.67 MiB 772.56 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7f6950b+dirty 1250.94 ms 1252.92 ms 1.98 ms
31fcca2+dirty 1222.04 ms 1226.51 ms 4.47 ms
8e80789+dirty 1235.66 ms 1223.78 ms -11.88 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
a5d86e1+dirty 1230.35 ms 1222.47 ms -7.88 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
27ef4ee+dirty 1236.41 ms 1244.90 ms 8.49 ms
ddc0552+dirty 1246.00 ms 1241.98 ms -4.02 ms
8ae23a7+dirty 1233.67 ms 1229.52 ms -4.15 ms

App size

Revision Plain With Sentry Diff
7f6950b+dirty 2.92 MiB 3.67 MiB 772.53 KiB
31fcca2+dirty 2.92 MiB 3.46 MiB 557.31 KiB
8e80789+dirty 2.92 MiB 3.67 MiB 772.00 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
a5d86e1+dirty 2.92 MiB 3.66 MiB 757.10 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
27ef4ee+dirty 2.92 MiB 3.41 MiB 503.72 KiB
ddc0552+dirty 2.92 MiB 3.67 MiB 772.47 KiB
8ae23a7+dirty 2.92 MiB 3.66 MiB 757.67 KiB

Previous results on branch: kw/add-rn-sdk-package-for-android

Startup times

Revision Plain With Sentry Diff
769451f+dirty 1236.65 ms 1236.31 ms -0.35 ms
bab8d22+dirty 1244.88 ms 1237.96 ms -6.92 ms

App size

Revision Plain With Sentry Diff
769451f+dirty 2.92 MiB 3.67 MiB 772.51 KiB
bab8d22+dirty 2.92 MiB 3.67 MiB 772.58 KiB

antonis
antonis reviewed Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good and worked as expected for me 🚀
I've added a couple of minor lint issues and a suggestion for a possible improvement.

@krystofwoldrich
Copy link
Member Author

@antonis Thanks for the comments and suggestions. I resolved the lint and added explanation to why I decided to change the version in code.

@krystofwoldrich krystofwoldrich mentioned this pull request Dec 17, 2024
Open
antonis
antonis approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit de59d3a into main Dec 17, 2024
63 of 64 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/add-rn-sdk-package-for-android branch December 17, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @antonis