Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecates Sentry/types #4368

Merged
merged 7 commits into from
Dec 18, 2024
Merged

chore: deprecates Sentry/types #4368

merged 7 commits into from
Dec 18, 2024

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Dec 13, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

@sentry/types package is deprecated with getsentry/sentry-javascript#14523 in 8.42.0. @sentry/core should be used instead.

💡 Motivation and Context

Fixes #4349

💚 How did you test it?

Manual testing with samples and CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Base automatically changed from deps/scripts/update-javascript.sh to main December 13, 2024 09:16
@antonis
Merge branch 'main' into antonis/deprecates-sentry-types
82e7d35 
# Conflicts:
#	samples/react-native-macos/package.json
#	yarn.lock
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 432.69 ms 433.61 ms 0.92 ms
Size 17.74 MiB 20.10 MiB 2.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
13f280b 486.16 ms 472.45 ms -13.71 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
e1ea4a8 506.82 ms 510.48 ms 3.66 ms
205982c 504.41 ms 505.70 ms 1.29 ms
f06c879 408.41 ms 424.54 ms 16.13 ms
83f6f6c 418.83 ms 410.94 ms -7.89 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms
7bc4d75 488.76 ms 473.28 ms -15.48 ms
3aecc61 479.21 ms 462.92 ms -16.29 ms
4a6664f 548.79 ms 585.00 ms 36.21 ms

App size

Revision Plain With Sentry Diff
13f280b 17.74 MiB 20.08 MiB 2.34 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e1ea4a8 17.74 MiB 20.08 MiB 2.34 MiB
205982c 17.74 MiB 20.10 MiB 2.36 MiB
f06c879 17.73 MiB 19.85 MiB 2.12 MiB
83f6f6c 17.74 MiB 20.09 MiB 2.35 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB
7bc4d75 17.74 MiB 20.08 MiB 2.34 MiB
3aecc61 17.74 MiB 20.10 MiB 2.36 MiB
4a6664f 17.73 MiB 19.94 MiB 2.21 MiB

Previous results on branch: antonis/deprecates-sentry-types

Startup times

Revision Plain With Sentry Diff
9fbf463 411.42 ms 417.00 ms 5.58 ms
df5046d 500.19 ms 499.04 ms -1.15 ms
79586c5 471.00 ms 451.65 ms -19.35 ms

App size

Revision Plain With Sentry Diff
9fbf463 17.74 MiB 20.10 MiB 2.36 MiB
df5046d 17.74 MiB 20.10 MiB 2.36 MiB
79586c5 17.74 MiB 20.10 MiB 2.36 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 396.94 ms 412.98 ms 16.04 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
9385d74+dirty 381.56 ms 416.02 ms 34.46 ms
1c65324+dirty 381.10 ms 427.26 ms 46.16 ms
6c56eb1+dirty 395.28 ms 378.52 ms -16.76 ms
ed3d77e+dirty 366.04 ms 411.33 ms 45.28 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
c2a4e9b+dirty 392.94 ms 474.55 ms 81.61 ms
f06c879+dirty 361.27 ms 407.88 ms 46.61 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
9cd0e9f+dirty 383.65 ms 418.65 ms 35.00 ms

App size

Revision Plain With Sentry Diff
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
9385d74+dirty 7.15 MiB 8.37 MiB 1.22 MiB
1c65324+dirty 7.15 MiB 8.22 MiB 1.07 MiB
6c56eb1+dirty 7.15 MiB 8.37 MiB 1.22 MiB
ed3d77e+dirty 7.15 MiB 8.35 MiB 1.21 MiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
c2a4e9b+dirty 7.15 MiB 8.34 MiB 1.19 MiB
f06c879+dirty 7.15 MiB 8.12 MiB 997.78 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
9cd0e9f+dirty 7.15 MiB 8.35 MiB 1.20 MiB

Previous results on branch: antonis/deprecates-sentry-types

Startup times

Revision Plain With Sentry Diff
79586c5+dirty 384.14 ms 427.23 ms 43.09 ms
df5046d+dirty 431.17 ms 507.45 ms 76.27 ms
9fbf463+dirty 410.37 ms 468.10 ms 57.73 ms

App size

Revision Plain With Sentry Diff
79586c5+dirty 7.15 MiB 8.37 MiB 1.22 MiB
df5046d+dirty 7.15 MiB 8.37 MiB 1.22 MiB
9fbf463+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.18 ms 1244.92 ms 1.73 ms
Size 2.92 MiB 3.69 MiB 789.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
416f465+dirty 1232.48 ms 1233.26 ms 0.78 ms
5571a20+dirty 1228.09 ms 1233.45 ms 5.36 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
62a750b+dirty 1228.12 ms 1230.53 ms 2.41 ms
2ec71da+dirty 1230.29 ms 1239.50 ms 9.21 ms
75774ea+dirty 1235.23 ms 1235.02 ms -0.21 ms
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms
9cd0e9f+dirty 1244.61 ms 1247.43 ms 2.82 ms
9282172+dirty 1227.60 ms 1232.69 ms 5.09 ms
d8668ce+dirty 1249.70 ms 1242.31 ms -7.39 ms

App size

Revision Plain With Sentry Diff
416f465+dirty 2.92 MiB 3.67 MiB 772.44 KiB
5571a20+dirty 2.92 MiB 3.48 MiB 575.54 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
62a750b+dirty 2.92 MiB 3.48 MiB 575.59 KiB
2ec71da+dirty 2.92 MiB 3.69 MiB 791.06 KiB
75774ea+dirty 2.92 MiB 3.66 MiB 763.01 KiB
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB
9cd0e9f+dirty 2.92 MiB 3.64 MiB 741.23 KiB
9282172+dirty 2.92 MiB 3.67 MiB 772.46 KiB
d8668ce+dirty 2.92 MiB 3.64 MiB 742.99 KiB

Previous results on branch: antonis/deprecates-sentry-types

Startup times

Revision Plain With Sentry Diff
79586c5+dirty 1229.35 ms 1234.26 ms 4.91 ms
df5046d+dirty 1223.08 ms 1230.43 ms 7.34 ms
9fbf463+dirty 1232.02 ms 1227.47 ms -4.55 ms

App size

Revision Plain With Sentry Diff
79586c5+dirty 2.92 MiB 3.67 MiB 771.93 KiB
df5046d+dirty 2.92 MiB 3.67 MiB 772.60 KiB
9fbf463+dirty 2.92 MiB 3.67 MiB 772.53 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.12 ms 1234.58 ms 5.46 ms
Size 2.36 MiB 3.12 MiB 778.59 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
416f465+dirty 1221.56 ms 1226.48 ms 4.92 ms
5571a20+dirty 1203.57 ms 1204.57 ms 1.00 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
62a750b+dirty 1216.60 ms 1229.14 ms 12.54 ms
2ec71da+dirty 1225.85 ms 1231.57 ms 5.72 ms
75774ea+dirty 1231.33 ms 1243.39 ms 12.06 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
9cd0e9f+dirty 1224.94 ms 1239.88 ms 14.94 ms
9282172+dirty 1237.27 ms 1242.20 ms 4.94 ms
d8668ce+dirty 1225.18 ms 1228.08 ms 2.90 ms

App size

Revision Plain With Sentry Diff
416f465+dirty 2.36 MiB 3.11 MiB 759.80 KiB
5571a20+dirty 2.36 MiB 2.92 MiB 569.93 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
62a750b+dirty 2.36 MiB 2.92 MiB 570.00 KiB
2ec71da+dirty 2.36 MiB 3.13 MiB 784.66 KiB
75774ea+dirty 2.36 MiB 3.10 MiB 757.87 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
9cd0e9f+dirty 2.36 MiB 3.08 MiB 735.56 KiB
9282172+dirty 2.36 MiB 3.11 MiB 759.89 KiB
d8668ce+dirty 2.36 MiB 3.08 MiB 737.08 KiB

Previous results on branch: antonis/deprecates-sentry-types

Startup times

Revision Plain With Sentry Diff
79586c5+dirty 1212.86 ms 1215.42 ms 2.55 ms
df5046d+dirty 1227.39 ms 1224.06 ms -3.33 ms
9fbf463+dirty 1235.83 ms 1241.71 ms 5.88 ms

App size

Revision Plain With Sentry Diff
79586c5+dirty 2.36 MiB 3.10 MiB 759.48 KiB
df5046d+dirty 2.36 MiB 3.11 MiB 760.03 KiB
9fbf463+dirty 2.36 MiB 3.11 MiB 760.05 KiB

@antonis antonis marked this pull request as ready for review December 13, 2024 10:12
@antonis
Merge branch 'main' into antonis/deprecates-sentry-types
0f29cbc 
# Conflicts:
#	samples/react-native-macos/package.json
#	yarn.lock
@antonis
Merge branch 'main' into antonis/deprecates-sentry-types
6ab8fc5 
# Conflicts:
#	samples/react-native-macos/package.json
#	yarn.lock
lucas-zimerman
lucas-zimerman approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for the PR

@lucas-zimerman lucas-zimerman enabled auto-merge (squash) December 18, 2024 13:26
@lucas-zimerman lucas-zimerman merged commit 18ce5e8 into main Dec 18, 2024
63 checks passed
@lucas-zimerman lucas-zimerman deleted the antonis/deprecates-sentry-types branch December 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate @sentry/types
3 participants
@antonis @lucas-zimerman @web-flow