Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bumps JavaScript SDK to v8.42.0 and deprecates sentry/types #4366

Closed
wants to merge 4 commits into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Dec 12, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Bumps JavaScript SDK to v8.42.0. Though the sentry/types deprecation shouldn't introduce breaking changes it seems to have broken the build. This PR replaces the deprecated sentry/types with sentry/core to fix this.
See #4325 for the changelog.

💡 Motivation and Context

Bumping #4325 from 8.42.0 to 8.42.0 introduced new changes. This PR attempts to handle the breaking changes of 8.42.0 first for simplicity #4325 (comment)

💚 How did you test it?

CI, Manually

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 378.40 ms 417.82 ms 39.42 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0d3e677+dirty 384.24 ms 431.45 ms 47.21 ms
d43a46b+dirty 417.65 ms 472.98 ms 55.33 ms
484813b+dirty 411.65 ms 456.02 ms 44.37 ms
fe13591+dirty 539.51 ms 597.92 ms 58.40 ms
f06c879+dirty 361.27 ms 407.88 ms 46.61 ms
e22745e+dirty 415.50 ms 448.76 ms 33.26 ms
9cd0e9f+dirty 383.65 ms 418.65 ms 35.00 ms
70e6261+dirty 395.08 ms 408.12 ms 13.04 ms
5a22220+dirty 384.61 ms 419.06 ms 34.45 ms
e540498+dirty 408.56 ms 480.00 ms 71.44 ms

App size

Revision Plain With Sentry Diff
0d3e677+dirty 7.15 MiB 8.35 MiB 1.20 MiB
d43a46b+dirty 7.15 MiB 8.34 MiB 1.19 MiB
484813b+dirty 7.15 MiB 8.34 MiB 1.19 MiB
fe13591+dirty 7.15 MiB 8.35 MiB 1.20 MiB
f06c879+dirty 7.15 MiB 8.12 MiB 997.78 KiB
e22745e+dirty 7.15 MiB 8.35 MiB 1.20 MiB
9cd0e9f+dirty 7.15 MiB 8.35 MiB 1.20 MiB
70e6261+dirty 7.15 MiB 8.21 MiB 1.07 MiB
5a22220+dirty 7.15 MiB 8.21 MiB 1.06 MiB
e540498+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@antonis antonis changed the title chore(deps): Bumps JavaScript SDK to v8.42.0 chore(deps): Bumps JavaScript SDK to v8.42.0 and deprecates sentry/types Dec 12, 2024
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 454.60 ms 444.02 ms -10.58 ms
Size 17.74 MiB 20.08 MiB 2.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
31fcca2 391.22 ms 414.78 ms 23.56 ms
77680ec 482.22 ms 475.07 ms -7.16 ms
9282172 486.12 ms 467.70 ms -18.42 ms
7fd512a 442.18 ms 437.57 ms -4.61 ms
946a600 384.53 ms 366.65 ms -17.88 ms
b8ff156 438.80 ms 454.14 ms 15.34 ms
148f924 492.65 ms 500.28 ms 7.63 ms
70e6261 482.65 ms 495.70 ms 13.05 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
575f9da 415.26 ms 422.98 ms 7.72 ms

App size

Revision Plain With Sentry Diff
31fcca2 17.73 MiB 19.90 MiB 2.17 MiB
77680ec 17.74 MiB 20.08 MiB 2.34 MiB
9282172 17.74 MiB 20.09 MiB 2.35 MiB
7fd512a 17.74 MiB 20.08 MiB 2.35 MiB
946a600 17.74 MiB 20.09 MiB 2.35 MiB
b8ff156 17.74 MiB 20.09 MiB 2.35 MiB
148f924 17.73 MiB 19.94 MiB 2.21 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
575f9da 17.73 MiB 19.83 MiB 2.10 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.23 ms 1219.38 ms 3.15 ms
Size 2.36 MiB 3.10 MiB 758.16 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fe13591+dirty 1208.25 ms 1219.53 ms 11.28 ms
8ab11b6+dirty 1203.23 ms 1206.02 ms 2.79 ms
b8ff156+dirty 1236.51 ms 1234.53 ms -1.98 ms
83f6f6c+dirty 1218.33 ms 1220.27 ms 1.93 ms
c2a4e9b+dirty 1240.10 ms 1239.22 ms -0.88 ms
abb7058+dirty 1255.42 ms 1268.86 ms 13.44 ms
07e58c9+dirty 1226.02 ms 1228.35 ms 2.33 ms
e22745e+dirty 1222.73 ms 1224.98 ms 2.25 ms
8c88ac7+dirty 1205.13 ms 1218.87 ms 13.74 ms
728164b+dirty 1256.10 ms 1259.08 ms 2.98 ms

App size

Revision Plain With Sentry Diff
fe13591+dirty 2.36 MiB 3.10 MiB 752.40 KiB
8ab11b6+dirty 2.36 MiB 3.11 MiB 759.83 KiB
b8ff156+dirty 2.36 MiB 3.11 MiB 759.80 KiB
83f6f6c+dirty 2.36 MiB 3.10 MiB 759.79 KiB
c2a4e9b+dirty 2.36 MiB 3.08 MiB 734.00 KiB
abb7058+dirty 2.36 MiB 2.87 MiB 520.42 KiB
07e58c9+dirty 2.36 MiB 3.10 MiB 752.28 KiB
e22745e+dirty 2.36 MiB 3.10 MiB 752.32 KiB
8c88ac7+dirty 2.36 MiB 3.10 MiB 752.63 KiB
728164b+dirty 2.36 MiB 2.88 MiB 530.38 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.18 ms 1214.27 ms -7.91 ms
Size 2.92 MiB 3.67 MiB 770.75 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fe13591+dirty 1250.69 ms 1246.27 ms -4.43 ms
8ab11b6+dirty 1222.91 ms 1216.08 ms -6.83 ms
b8ff156+dirty 1238.92 ms 1239.57 ms 0.66 ms
83f6f6c+dirty 1232.02 ms 1229.15 ms -2.87 ms
c2a4e9b+dirty 1247.39 ms 1243.04 ms -4.35 ms
abb7058+dirty 1260.28 ms 1266.56 ms 6.28 ms
07e58c9+dirty 1216.42 ms 1210.60 ms -5.82 ms
e22745e+dirty 1246.02 ms 1233.60 ms -12.42 ms
8c88ac7+dirty 1240.66 ms 1247.42 ms 6.76 ms
728164b+dirty 1280.06 ms 1285.26 ms 5.20 ms

App size

Revision Plain With Sentry Diff
fe13591+dirty 2.92 MiB 3.66 MiB 757.71 KiB
8ab11b6+dirty 2.92 MiB 3.67 MiB 772.38 KiB
b8ff156+dirty 2.92 MiB 3.67 MiB 772.38 KiB
83f6f6c+dirty 2.92 MiB 3.67 MiB 772.37 KiB
c2a4e9b+dirty 2.92 MiB 3.64 MiB 739.91 KiB
abb7058+dirty 2.92 MiB 3.43 MiB 524.53 KiB
07e58c9+dirty 2.92 MiB 3.66 MiB 756.65 KiB
e22745e+dirty 2.92 MiB 3.66 MiB 756.73 KiB
8c88ac7+dirty 2.92 MiB 3.66 MiB 757.12 KiB
728164b+dirty 2.92 MiB 3.44 MiB 533.26 KiB

@antonis
Copy link
Collaborator Author

antonis commented Dec 13, 2024

Closing as the breaking change is fixed with later JS SDK versions #4325 (comment)

@antonis antonis closed this Dec 13, 2024
@antonis antonis deleted the antonis/bump-js-8.42.0 branch December 13, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants