feat(core): Drop dev server spans #4271

antonis · 2024-11-13T13:49:59Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Filters out development server spans using the shouldCreateSpanForRequest option.

💡 Motivation and Context

Fixes #3210

💚 How did you test it?

Manual testing, Unit tests

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2024-11-13T14:13:25Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	364.80 ms	423.88 ms	59.08 ms
Size	7.15 MiB	8.35 MiB	1.20 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`2ec71da`+dirty	375.64 ms	431.59 ms	55.95 ms
`8c88ac7`+dirty	402.72 ms	434.32 ms	31.60 ms
`728164b`+dirty	335.93 ms	342.94 ms	7.01 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`d0bf494`+dirty	253.73 ms	308.23 ms	54.49 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`e540498`+dirty	408.56 ms	480.00 ms	71.44 ms
`c639edf`+dirty	363.39 ms	414.78 ms	51.39 ms
`6e8584e`+dirty	383.37 ms	400.84 ms	17.47 ms

App size

Revision	Plain	With Sentry	Diff
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`2ec71da`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`8c88ac7`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`728164b`+dirty	7.15 MiB	8.12 MiB	997.71 KiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`d0bf494`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`e540498`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`c639edf`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`6e8584e`+dirty	7.15 MiB	8.13 MiB	1002.18 KiB

Previous results on branch: antonis/drop-dev-server-spans

Startup times

Revision	Plain	With Sentry	Diff
`a3b7a1a`+dirty	394.36 ms	445.27 ms	50.91 ms
`db6b5be`+dirty	409.73 ms	479.62 ms	69.89 ms
`4fb3780`+dirty	371.15 ms	403.76 ms	32.60 ms

App size

Revision	Plain	With Sentry	Diff
`a3b7a1a`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`db6b5be`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`4fb3780`+dirty	7.15 MiB	8.35 MiB	1.20 MiB

github-actions · 2024-11-13T14:23:36Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1203.09 ms	1207.52 ms	4.43 ms
Size	2.36 MiB	3.10 MiB	753.45 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`457e29f`+dirty	1253.94 ms	1269.18 ms	15.24 ms
`d43a46b`+dirty	1219.24 ms	1219.65 ms	0.41 ms
`e5bc97b`+dirty	1230.63 ms	1234.83 ms	4.20 ms
`9c48b2c`+dirty	1246.96 ms	1255.73 ms	8.77 ms
`c639edf`+dirty	1236.18 ms	1235.04 ms	-1.14 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`52c0562`+dirty	1219.34 ms	1221.25 ms	1.91 ms
`5446992`+dirty	1273.28 ms	1276.68 ms	3.40 ms
`0677344`+dirty	1276.70 ms	1300.07 ms	23.37 ms
`8ae23a7`+dirty	1230.02 ms	1227.62 ms	-2.40 ms

App size

Revision	Plain	With Sentry	Diff
`457e29f`+dirty	2.36 MiB	2.87 MiB	520.67 KiB
`d43a46b`+dirty	2.36 MiB	3.08 MiB	734.25 KiB
`e5bc97b`+dirty	2.36 MiB	3.10 MiB	753.14 KiB
`9c48b2c`+dirty	2.36 MiB	2.85 MiB	495.77 KiB
`c639edf`+dirty	2.36 MiB	3.08 MiB	736.63 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`52c0562`+dirty	2.36 MiB	3.14 MiB	793.36 KiB
`5446992`+dirty	2.36 MiB	2.88 MiB	531.94 KiB
`0677344`+dirty	2.36 MiB	2.85 MiB	496.81 KiB
`8ae23a7`+dirty	2.36 MiB	3.10 MiB	752.42 KiB

Previous results on branch: antonis/drop-dev-server-spans

Startup times

Revision	Plain	With Sentry	Diff
`a3b7a1a`+dirty	1232.47 ms	1242.38 ms	9.91 ms
`4fb3780`+dirty	1243.47 ms	1245.06 ms	1.59 ms
`db6b5be`+dirty	1236.12 ms	1231.77 ms	-4.35 ms

App size

Revision	Plain	With Sentry	Diff
`a3b7a1a`+dirty	2.36 MiB	3.10 MiB	752.47 KiB
`4fb3780`+dirty	2.36 MiB	3.10 MiB	752.22 KiB
`db6b5be`+dirty	2.36 MiB	3.10 MiB	752.22 KiB

github-actions · 2024-11-13T14:30:44Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1238.94 ms	1245.60 ms	6.67 ms
Size	2.92 MiB	3.66 MiB	758.65 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`457e29f`+dirty	1256.71 ms	1258.50 ms	1.79 ms
`d43a46b`+dirty	1223.31 ms	1230.92 ms	7.61 ms
`e5bc97b`+dirty	1229.17 ms	1227.64 ms	-1.54 ms
`9c48b2c`+dirty	1253.39 ms	1256.30 ms	2.91 ms
`c639edf`+dirty	1223.63 ms	1227.98 ms	4.35 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms
`52c0562`+dirty	1233.94 ms	1226.29 ms	-7.65 ms
`5446992`+dirty	1249.94 ms	1254.80 ms	4.86 ms
`0677344`+dirty	1252.52 ms	1254.08 ms	1.56 ms
`8ae23a7`+dirty	1233.67 ms	1229.52 ms	-4.15 ms

App size

Revision	Plain	With Sentry	Diff
`457e29f`+dirty	2.92 MiB	3.43 MiB	524.75 KiB
`d43a46b`+dirty	2.92 MiB	3.64 MiB	740.29 KiB
`e5bc97b`+dirty	2.92 MiB	3.66 MiB	758.40 KiB
`9c48b2c`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`c639edf`+dirty	2.92 MiB	3.64 MiB	742.55 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB
`52c0562`+dirty	2.92 MiB	3.69 MiB	794.15 KiB
`5446992`+dirty	2.92 MiB	3.44 MiB	535.26 KiB
`0677344`+dirty	2.92 MiB	3.41 MiB	500.94 KiB
`8ae23a7`+dirty	2.92 MiB	3.66 MiB	757.67 KiB

Previous results on branch: antonis/drop-dev-server-spans

Startup times

Revision	Plain	With Sentry	Diff
`a3b7a1a`+dirty	1218.67 ms	1217.96 ms	-0.71 ms
`4fb3780`+dirty	1228.67 ms	1225.65 ms	-3.02 ms
`db6b5be`+dirty	1240.06 ms	1246.98 ms	6.92 ms

App size

Revision	Plain	With Sentry	Diff
`a3b7a1a`+dirty	2.92 MiB	3.66 MiB	756.96 KiB
`4fb3780`+dirty	2.92 MiB	3.66 MiB	756.82 KiB
`db6b5be`+dirty	2.92 MiB	3.66 MiB	756.80 KiB

github-actions · 2024-11-13T14:56:47Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	466.84 ms	472.96 ms	6.12 ms
Size	17.74 MiB	20.08 MiB	2.34 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`fe13591`	478.92 ms	480.84 ms	1.92 ms
`4cc5c27`	460.04 ms	496.32 ms	36.28 ms
`cdf2f33`	469.46 ms	462.17 ms	-7.29 ms
`d43a46b`	454.22 ms	477.79 ms	23.57 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`5a22220`	412.38 ms	447.35 ms	34.97 ms
`d0bf494`+dirty	375.37 ms	395.14 ms	19.77 ms
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms
`0d3e677`	422.82 ms	411.90 ms	-10.92 ms

App size

Revision	Plain	With Sentry	Diff
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`fe13591`	17.74 MiB	20.07 MiB	2.34 MiB
`4cc5c27`	17.73 MiB	19.95 MiB	2.21 MiB
`cdf2f33`	17.74 MiB	20.08 MiB	2.34 MiB
`d43a46b`	17.73 MiB	20.06 MiB	2.33 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`5a22220`	17.73 MiB	19.93 MiB	2.20 MiB
`d0bf494`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`0d3e677`	17.74 MiB	20.07 MiB	2.34 MiB

Previous results on branch: antonis/drop-dev-server-spans

Startup times

Revision	Plain	With Sentry	Diff
`a3b7a1a`	467.49 ms	461.06 ms	-6.43 ms
`db6b5be`	477.83 ms	512.89 ms	35.06 ms
`4fb3780`	508.12 ms	498.46 ms	-9.66 ms

App size

Revision	Plain	With Sentry	Diff
`a3b7a1a`	17.74 MiB	20.08 MiB	2.34 MiB
`db6b5be`	17.74 MiB	20.08 MiB	2.34 MiB
`4fb3780`	17.74 MiB	20.08 MiB	2.34 MiB

github-actions · 2024-11-13T16:30:25Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 241c8e6

packages/core/src/js/tracing/reactnativetracing.ts

packages/core/test/tracing/reactnavigation.test.ts

lucas-zimerman · 2024-11-13T19:01:29Z

Overall, the PR looks good, but I have some concerns when devserver doesn't exist. Thank you for the contribution!

Co-authored-by: LucasZF <[email protected]>

lucas-zimerman

Now it's looking good! LGTM!

# Conflicts: # CHANGELOG.md

antonis added 2 commits November 13, 2024 15:49

Drop dev server spans

53f6986

Adds changelog

36b6282

Adds tests

db32d09

Revert unneeded change

ec23f7e

antonis marked this pull request as ready for review November 13, 2024 15:18

antonis requested review from krystofwoldrich and lucas-zimerman as code owners November 13, 2024 15:18

antonis changed the title ~~Drop dev server spans~~ feat(core): Drop dev server spans Nov 13, 2024

lucas-zimerman reviewed Nov 13, 2024

View reviewed changes

packages/core/src/js/tracing/reactnativetracing.ts Outdated Show resolved Hide resolved

lucas-zimerman reviewed Nov 13, 2024

View reviewed changes

packages/core/test/tracing/reactnavigation.test.ts Show resolved Hide resolved

antonis and others added 3 commits November 14, 2024 10:21

Handle undefined dev server urls

ffcf870

Co-authored-by: LucasZF <[email protected]>

Adds tests for the case when the dev server url is undefined

5291fb1

Merge branch 'main' into antonis/drop-dev-server-spans

31e5d83

antonis requested a review from lucas-zimerman November 14, 2024 08:37

lucas-zimerman approved these changes Nov 14, 2024

View reviewed changes

antonis added 4 commits November 15, 2024 14:55

Use startsWith to check url matching

30a702e

Merge branch 'main' into antonis/drop-dev-server-spans

bb60d47

Moves changelog to the unreleased section

feaab43

Merge branch 'main' into antonis/drop-dev-server-spans

241c8e6

# Conflicts: # CHANGELOG.md

antonis merged commit 13f280b into main Nov 18, 2024
63 checks passed

antonis deleted the antonis/drop-dev-server-spans branch November 18, 2024 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): Drop dev server spans #4271

feat(core): Drop dev server spans #4271

antonis commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/drop-dev-server-spans

Startup times

App size

github-actions bot commented Nov 13, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/drop-dev-server-spans

Startup times

App size

github-actions bot commented Nov 13, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/drop-dev-server-spans

Startup times

App size

github-actions bot commented Nov 13, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/drop-dev-server-spans

Startup times

App size

github-actions bot commented Nov 13, 2024 •

edited

Loading

lucas-zimerman commented Nov 13, 2024

lucas-zimerman left a comment

feat(core): Drop dev server spans #4271

feat(core): Drop dev server spans #4271

Conversation

antonis commented Nov 13, 2024 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Nov 13, 2024 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/drop-dev-server-spans

Startup times

App size

github-actions bot commented Nov 13, 2024 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/drop-dev-server-spans

Startup times

App size

github-actions bot commented Nov 13, 2024 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/drop-dev-server-spans

Startup times

App size

github-actions bot commented Nov 13, 2024 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/drop-dev-server-spans

Startup times

App size

github-actions bot commented Nov 13, 2024 • edited Loading

lucas-zimerman commented Nov 13, 2024

lucas-zimerman left a comment

Choose a reason for hiding this comment

antonis commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading