feat(replay): Add Mask and Unmask Android implementation #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-redact-components
…-redact-components
…getsentry/sentry-react-native into kw/feat/replay-custom-redact-components
…eplay-custom-redact-android
…eplay-custom-redact-android
Co-authored-by: LucasZF <[email protected]>
…eplay-custom-redact-android
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2b64fe+dirty | 1232.22 ms | 1255.20 ms | 22.98 ms |
| 4cc5c27+dirty | 1211.45 ms | 1214.60 ms | 3.16 ms |
| 1c65324+dirty | 1235.17 ms | 1235.08 ms | -0.09 ms |
| cdf2f33+dirty | 1227.71 ms | 1233.94 ms | 6.22 ms |
| e1ea4a8+dirty | 1233.49 ms | 1237.71 ms | 4.22 ms |
| dadc233+dirty | 1223.20 ms | 1236.88 ms | 13.68 ms |
| ed3d77e+dirty | 1214.61 ms | 1205.83 ms | -8.78 ms |
| 2ec71da+dirty | 1225.85 ms | 1231.57 ms | 5.72 ms |
| 9cd0e9f+dirty | 1224.94 ms | 1239.88 ms | 14.94 ms |
| 0db0c72+dirty | 1275.02 ms | 1285.84 ms | 10.82 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2b64fe+dirty | 2.36 MiB | 2.85 MiB | 495.80 KiB |
| 4cc5c27+dirty | 2.36 MiB | 3.04 MiB | 698.52 KiB |
| 1c65324+dirty | 2.36 MiB | 3.04 MiB | 698.64 KiB |
| cdf2f33+dirty | 2.36 MiB | 3.10 MiB | 751.38 KiB |
| e1ea4a8+dirty | 2.36 MiB | 3.10 MiB | 752.31 KiB |
| dadc233+dirty | 2.36 MiB | 2.84 MiB | 486.85 KiB |
| ed3d77e+dirty | 2.36 MiB | 3.10 MiB | 753.32 KiB |
| 2ec71da+dirty | 2.36 MiB | 3.13 MiB | 784.66 KiB |
| 9cd0e9f+dirty | 2.36 MiB | 3.08 MiB | 735.56 KiB |
| 0db0c72+dirty | 2.36 MiB | 2.84 MiB | 487.01 KiB |
krystofwoldrich
requested review from
lucas-zimerman and
antonis
as code owners
|
@antonis @lucas-zimerman This is a follow up to #4224, but this time for Android. |
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ae23a7 | 526.83 ms | 513.38 ms | -13.45 ms |
| 4297324 | 536.61 ms | 542.48 ms | 5.87 ms |
| dadc233+dirty | 333.78 ms | 343.94 ms | 10.16 ms |
| c2a4e9b | 480.42 ms | 485.60 ms | 5.18 ms |
| 9433f35 | 347.64 ms | 356.22 ms | 8.58 ms |
| 9a3ca65+dirty | 326.93 ms | 330.14 ms | 3.21 ms |
| 7bc4d75 | 488.76 ms | 473.28 ms | -15.48 ms |
| 0d3e677 | 422.82 ms | 411.90 ms | -10.92 ms |
| 80b2ce3 | 385.02 ms | 387.36 ms | 2.34 ms |
| 1d86dd6 | 405.14 ms | 411.06 ms | 5.92 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ae23a7 | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| 4297324 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| dadc233+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| c2a4e9b | 17.73 MiB | 20.06 MiB | 2.33 MiB |
| 9433f35 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
| 9a3ca65+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 7bc4d75 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 0d3e677 | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| 80b2ce3 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 1d86dd6 | 17.73 MiB | 19.86 MiB | 2.12 MiB |
lucas-zimerman
approved these changes
Nov 25, 2024
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d43a46b+dirty | 417.65 ms | 472.98 ms | 55.33 ms |
| 4297324+dirty | 385.33 ms | 435.68 ms | 50.35 ms |
| 13f280b+dirty | 376.13 ms | 406.41 ms | 30.28 ms |
| dadc233+dirty | 363.19 ms | 370.37 ms | 7.18 ms |
| 9a3ca65+dirty | 344.96 ms | 358.92 ms | 13.96 ms |
| e2b64fe+dirty | 258.82 ms | 304.26 ms | 45.44 ms |
| 8ae23a7+dirty | 398.10 ms | 411.48 ms | 13.38 ms |
| 27ef4ee+dirty | 296.71 ms | 351.00 ms | 54.29 ms |
| eb1e19f+dirty | 391.37 ms | 418.27 ms | 26.90 ms |
| 86d6d2c+dirty | 267.21 ms | 325.24 ms | 58.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d43a46b+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| 4297324+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 13f280b+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| dadc233+dirty | 7.15 MiB | 8.04 MiB | 910.84 KiB |
| 9a3ca65+dirty | 7.15 MiB | 8.09 MiB | 962.83 KiB |
| e2b64fe+dirty | 7.15 MiB | 8.07 MiB | 947.16 KiB |
| 8ae23a7+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 27ef4ee+dirty | 7.15 MiB | 8.08 MiB | 959.49 KiB |
| eb1e19f+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 86d6d2c+dirty | 7.15 MiB | 8.09 MiB | 962.69 KiB |
antonis
reviewed
Nov 25, 2024
antonis
reviewed
Nov 25, 2024
packages/core/android/src/newarch/java/io/sentry/react/replay/RNSentryReplayUnmaskManager.java
Outdated
Show resolved
Hide resolved
antonis
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
LGTM 🚀
Added a questions/nitpick with https://github.com/getsentry/sentry-react-native/pull/4265/files#r1856782186
Base automatically changed from
kw/feat/replay-custom-redact-components
to
main
November 25, 2024 16:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR adds new and legacy architecture impl of Mask and Unmask wrappers for custom redact of React Native components.
This is a follow up to feat(replay): Add SentryMask and SentryUnmask iOS components #4224
This PR needs sentry-android feat(replay): Add Mask/Unmask Containers for custom masking in hybrid SDKs sentry-java#3881
Legacy Arch Sample Replay
New Arch Sample Replay
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps