Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gradle): DISABLE_NATIVE_UPLOAD should not affect JS source maps upload #4263

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix(gradle): DISABLE_NATIVE_UPLOAD should not affect JS source maps upload #4263

merged 1 commit into from
Nov 12, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix

📜 Description

The new disable native upload flag was not released yet.

This fixes case when the native upload is disabled but still JS source maps should be uploaded.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

#skip-changelog

@krystofwoldrich krystofwoldrich mentioned this pull request Nov 12, 2024
Merged
9 tasks
@github-actions GitHub Actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 452.47 ms 456.39 ms 3.92 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

antonis
antonis approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@github-actions GitHub Actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 379.04 ms 411.36 ms 32.32 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: antonis/android-skip-upload

Startup times

Revision Plain With Sentry Diff
c484309+dirty 373.04 ms 401.94 ms 28.90 ms

App size

Revision Plain With Sentry Diff
c484309+dirty 7.15 MiB 8.35 MiB 1.20 MiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.04 ms 1228.41 ms 9.37 ms
Size 2.36 MiB 3.10 MiB 752.63 KiB

Baseline results on branch: antonis/android-skip-upload

Startup times

Revision Plain With Sentry Diff
c484309+dirty 1207.47 ms 1209.54 ms 2.07 ms

App size

Revision Plain With Sentry Diff
c484309+dirty 2.36 MiB 3.10 MiB 752.62 KiB

@antonis antonis merged commit 18b71e5 into antonis/android-skip-upload Nov 12, 2024
52 of 53 checks passed
@antonis antonis deleted the krystofwoldrich-patch-1 branch November 12, 2024 12:59
@github-actions GitHub Actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.09 ms 1230.19 ms -6.90 ms
Size 2.92 MiB 3.66 MiB 757.18 KiB

Baseline results on branch: antonis/android-skip-upload

Startup times

Revision Plain With Sentry Diff
c484309+dirty 1230.29 ms 1225.92 ms -4.37 ms

App size

Revision Plain With Sentry Diff
c484309+dirty 2.92 MiB 3.66 MiB 757.18 KiB

antonis added a commit that referenced this pull request Nov 12, 2024
@antonis @krystofwoldrich
Fix: Aligns Android autoupload logic with iOS (#4262)
63ed251 
* Aligns Android autoupload logic with iOS

* fix(gradle): DISABLE_NATIVE_UPLOAD should not affect JS source maps upload (#4263)

---------

Co-authored-by: Krystof Woldrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @antonis