Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Export missing SeverityLevel from types #4260

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

lucas-zimerman
Copy link
Collaborator

This PR adds the missing export SeverityLevel from @sentry/types.

@lucas-zimerman lucas-zimerman marked this pull request as ready for review November 11, 2024 16:25
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 395.80 ms 455.46 ms 59.65 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
f06c879+dirty 361.27 ms 407.88 ms 46.61 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
e540498+dirty 408.56 ms 480.00 ms 71.44 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
2ec71da+dirty 375.64 ms 431.59 ms 55.95 ms
c639edf+dirty 363.39 ms 414.78 ms 51.39 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
f06c879+dirty 7.15 MiB 8.12 MiB 997.78 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
e540498+dirty 7.15 MiB 8.38 MiB 1.23 MiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
2ec71da+dirty 7.15 MiB 8.38 MiB 1.23 MiB
c639edf+dirty 7.15 MiB 8.35 MiB 1.20 MiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.06 ms 1223.57 ms -2.49 ms
Size 2.36 MiB 3.10 MiB 752.62 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0d3e677+dirty 1214.39 ms 1225.70 ms 11.31 ms
d361d38+dirty 1246.04 ms 1267.12 ms 21.08 ms
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
700cbf4+dirty 1234.59 ms 1227.71 ms -6.88 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
abb7058+dirty 1255.42 ms 1268.86 ms 13.44 ms
9cab16b+dirty 1237.76 ms 1234.00 ms -3.76 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
148f924+dirty 1214.76 ms 1215.73 ms 0.97 ms
a5d86e1+dirty 1242.47 ms 1239.94 ms -2.53 ms

App size

Revision Plain With Sentry Diff
0d3e677+dirty 2.36 MiB 3.10 MiB 753.12 KiB
d361d38+dirty 2.36 MiB 2.85 MiB 499.84 KiB
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
700cbf4+dirty 2.36 MiB 3.08 MiB 734.22 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
abb7058+dirty 2.36 MiB 2.87 MiB 520.42 KiB
9cab16b+dirty 2.36 MiB 3.08 MiB 737.23 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
148f924+dirty 2.36 MiB 3.04 MiB 696.25 KiB
a5d86e1+dirty 2.36 MiB 3.10 MiB 752.65 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.70 ms 1224.21 ms 8.51 ms
Size 2.92 MiB 3.66 MiB 757.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0d3e677+dirty 1239.02 ms 1241.22 ms 2.20 ms
d361d38+dirty 1272.96 ms 1291.70 ms 18.74 ms
9433f35+dirty 1232.24 ms 1232.74 ms 0.50 ms
700cbf4+dirty 1233.96 ms 1228.27 ms -5.69 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
abb7058+dirty 1260.28 ms 1266.56 ms 6.28 ms
9cab16b+dirty 1236.10 ms 1247.16 ms 11.06 ms
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms
148f924+dirty 1220.72 ms 1221.30 ms 0.58 ms
a5d86e1+dirty 1230.35 ms 1222.47 ms -7.88 ms

App size

Revision Plain With Sentry Diff
0d3e677+dirty 2.92 MiB 3.66 MiB 758.42 KiB
d361d38+dirty 2.92 MiB 3.41 MiB 503.57 KiB
9433f35+dirty 2.92 MiB 3.41 MiB 503.55 KiB
700cbf4+dirty 2.92 MiB 3.64 MiB 740.57 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
abb7058+dirty 2.92 MiB 3.43 MiB 524.53 KiB
9cab16b+dirty 2.92 MiB 3.64 MiB 743.06 KiB
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB
148f924+dirty 2.92 MiB 3.60 MiB 701.88 KiB
a5d86e1+dirty 2.92 MiB 3.66 MiB 757.10 KiB

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit 8c88ac7 into main Nov 11, 2024
55 of 57 checks passed
@krystofwoldrich krystofwoldrich deleted the lz/fix-missing-export branch November 11, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants