fix(replay): RN Classes to redact were not used by cocoa #4243

krystofwoldrich · 2024-11-07T09:58:41Z

📢 Type of change

Bugfix

📜 Description

This PR fixes bug introduced during upgrade of cocoa #4156

Bug released in https://github.com/getsentry/sentry-react-native/releases/tag/5.34.0 and https://github.com/getsentry/sentry-react-native/releases/tag/6.0.0

💚 How did you test it?

locally running sample app, added tests

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

github-actions · 2024-11-07T10:25:47Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	477.29 ms	461.33 ms	-15.96 ms
Size	17.74 MiB	20.08 MiB	2.34 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`70e6261`	482.65 ms	495.70 ms	13.05 ms
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`22e31b6`	396.48 ms	419.64 ms	23.16 ms
`fe13591`	478.92 ms	480.84 ms	1.92 ms
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms
`ad6c299`	375.94 ms	382.02 ms	6.08 ms
`abb7058`	370.27 ms	389.58 ms	19.31 ms
`2ec71da`	438.14 ms	460.46 ms	22.32 ms
`31fcca2`	391.22 ms	414.78 ms	23.56 ms
`62a750b`	395.96 ms	423.36 ms	27.41 ms

App size

Revision	Plain	With Sentry	Diff
`70e6261`	17.73 MiB	19.94 MiB	2.21 MiB
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`22e31b6`	17.73 MiB	19.84 MiB	2.10 MiB
`fe13591`	17.74 MiB	20.07 MiB	2.34 MiB
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`ad6c299`	17.73 MiB	19.75 MiB	2.02 MiB
`abb7058`	17.73 MiB	19.83 MiB	2.10 MiB
`2ec71da`	17.73 MiB	20.10 MiB	2.37 MiB
`31fcca2`	17.73 MiB	19.90 MiB	2.17 MiB
`62a750b`	17.73 MiB	19.93 MiB	2.20 MiB

Previous results on branch: kw/fix/ios-replay-redact

Startup times

Revision	Plain	With Sentry	Diff
`df972ae`	459.49 ms	443.53 ms	-15.96 ms

App size

Revision	Plain	With Sentry	Diff
`df972ae`	17.74 MiB	20.08 MiB	2.34 MiB

github-actions · 2024-11-07T10:34:43Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	368.83 ms	419.42 ms	50.59 ms
Size	7.15 MiB	8.35 MiB	1.20 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ac41368`+dirty	395.91 ms	451.17 ms	55.26 ms
`4297324`+dirty	385.33 ms	435.68 ms	50.35 ms
`d8668ce`+dirty	372.43 ms	403.84 ms	31.41 ms
`e2b64fe`+dirty	258.82 ms	304.26 ms	45.44 ms
`5446992`+dirty	371.61 ms	390.00 ms	18.39 ms
`a989877`+dirty	383.04 ms	400.92 ms	17.88 ms
`9cab16b`+dirty	370.82 ms	416.37 ms	45.55 ms
`4a6664f`+dirty	357.02 ms	394.91 ms	37.89 ms
`e5bc97b`+dirty	409.10 ms	471.61 ms	62.51 ms
`700cbf4`+dirty	411.71 ms	485.52 ms	73.81 ms

App size

Revision	Plain	With Sentry	Diff
`ac41368`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`4297324`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`d8668ce`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`e2b64fe`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`5446992`+dirty	7.15 MiB	8.12 MiB	999.45 KiB
`a989877`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`9cab16b`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`4a6664f`+dirty	7.15 MiB	8.22 MiB	1.07 MiB
`e5bc97b`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`700cbf4`+dirty	7.15 MiB	8.34 MiB	1.19 MiB

github-actions · 2024-11-07T10:37:25Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1232.35 ms	1235.68 ms	3.33 ms
Size	2.92 MiB	3.66 MiB	755.40 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	1266.20 ms	1267.52 ms	1.32 ms
`5a22220`+dirty	1246.18 ms	1249.61 ms	3.43 ms
`c398f67`+dirty	1227.31 ms	1230.00 ms	2.69 ms
`27ef4ee`+dirty	1236.41 ms	1244.90 ms	8.49 ms
`d8668ce`+dirty	1249.70 ms	1242.31 ms	-7.39 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms
`9c48b2c`+dirty	1253.39 ms	1256.30 ms	2.91 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`eb1e19f`+dirty	1229.91 ms	1231.63 ms	1.71 ms

App size

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	2.92 MiB	3.40 MiB	488.08 KiB
`5a22220`+dirty	2.92 MiB	3.48 MiB	575.81 KiB
`c398f67`+dirty	2.92 MiB	3.60 MiB	701.89 KiB
`27ef4ee`+dirty	2.92 MiB	3.41 MiB	503.72 KiB
`d8668ce`+dirty	2.92 MiB	3.64 MiB	742.99 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB
`9c48b2c`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`eb1e19f`+dirty	2.92 MiB	3.64 MiB	742.82 KiB

Previous results on branch: kw/fix/ios-replay-redact

Startup times

Revision	Plain	With Sentry	Diff
`df972ae`+dirty	1236.86 ms	1231.91 ms	-4.94 ms

App size

Revision	Plain	With Sentry	Diff
`df972ae`+dirty	2.92 MiB	3.66 MiB	755.40 KiB

github-actions · 2024-11-07T10:43:11Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1222.63 ms	1225.92 ms	3.29 ms
Size	2.36 MiB	3.10 MiB	751.54 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	1289.40 ms	1298.40 ms	9.00 ms
`5a22220`+dirty	1209.49 ms	1220.94 ms	11.45 ms
`c398f67`+dirty	1219.67 ms	1225.66 ms	5.99 ms
`27ef4ee`+dirty	1293.52 ms	1296.08 ms	2.56 ms
`d8668ce`+dirty	1225.18 ms	1228.08 ms	2.90 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`9c48b2c`+dirty	1246.96 ms	1255.73 ms	8.77 ms
`70caa60`+dirty	1218.27 ms	1230.30 ms	12.03 ms
`eb1e19f`+dirty	1209.56 ms	1214.94 ms	5.38 ms

App size

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	2.36 MiB	2.83 MiB	481.15 KiB
`5a22220`+dirty	2.36 MiB	2.92 MiB	570.21 KiB
`c398f67`+dirty	2.36 MiB	3.04 MiB	696.27 KiB
`27ef4ee`+dirty	2.36 MiB	2.85 MiB	500.03 KiB
`d8668ce`+dirty	2.36 MiB	3.08 MiB	737.08 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`9c48b2c`+dirty	2.36 MiB	2.85 MiB	495.77 KiB
`70caa60`+dirty	2.36 MiB	2.83 MiB	479.27 KiB
`eb1e19f`+dirty	2.36 MiB	3.08 MiB	737.21 KiB

Previous results on branch: kw/fix/ios-replay-redact

Startup times

Revision	Plain	With Sentry	Diff
`df972ae`+dirty	1211.71 ms	1213.28 ms	1.56 ms

App size

Revision	Plain	With Sentry	Diff
`df972ae`+dirty	2.36 MiB	3.10 MiB	751.57 KiB

antonis

LGTM 🚀
Thank you for the test coverage 🙇

github-actions · 2024-11-25T14:58:22Z

	Fails
🚫	Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- RN Classes to redact were not used by cocoa ([#4243](https://github.com/getsentry/sentry-react-native/pull/4243))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against a06f6b1

fix(replay): RN Classes to redact were not used by cocoa

c414b47

krystofwoldrich force-pushed the kw/fix/ios-replay-redact branch from f3bb712 to c414b47 Compare November 7, 2024 10:04

krystofwoldrich added 2 commits November 7, 2024 11:08

fix the xcode project

3a1ecd0

add changelog

1fa34c9

krystofwoldrich requested a review from brustolin November 7, 2024 10:11

krystofwoldrich marked this pull request as ready for review November 7, 2024 10:12

krystofwoldrich requested review from lucas-zimerman and antonis as code owners November 7, 2024 10:12

krystofwoldrich changed the title ~~Kw/fix/ios replay redact~~ fix(replay): RN Classes to redact were not used by cocoa Nov 7, 2024

fix clang lint

bb4e1ac

antonis approved these changes Nov 7, 2024

View reviewed changes

Merge branch 'main' into kw/fix/ios-replay-redact

a06f6b1

krystofwoldrich enabled auto-merge (squash) November 7, 2024 12:35

krystofwoldrich merged commit b2bb1be into main Nov 7, 2024
52 of 54 checks passed

krystofwoldrich deleted the kw/fix/ios-replay-redact branch November 7, 2024 12:37

krystofwoldrich mentioned this pull request Nov 25, 2024

fix(replay): Backport iOS masking fixes from RN SDK v6 #4309

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(replay): RN Classes to redact were not used by cocoa #4243

fix(replay): RN Classes to redact were not used by cocoa #4243

krystofwoldrich commented Nov 7, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/fix/ios-replay-redact

Startup times

App size

github-actions bot commented Nov 7, 2024

Baseline results on branch: main

Startup times

App size

github-actions bot commented Nov 7, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/fix/ios-replay-redact

Startup times

App size

github-actions bot commented Nov 7, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/fix/ios-replay-redact

Startup times

App size

antonis left a comment

github-actions bot commented Nov 25, 2024

fix(replay): RN Classes to redact were not used by cocoa #4243

fix(replay): RN Classes to redact were not used by cocoa #4243

Conversation

krystofwoldrich commented Nov 7, 2024 • edited Loading

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

github-actions bot commented Nov 7, 2024 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/fix/ios-replay-redact

Startup times

App size

github-actions bot commented Nov 7, 2024

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Nov 7, 2024 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/fix/ios-replay-redact

Startup times

App size

github-actions bot commented Nov 7, 2024 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/fix/ios-replay-redact

Startup times

App size

antonis left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 25, 2024

Instructions and example for changelog

krystofwoldrich commented Nov 7, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024 •

edited

Loading