Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump E2E RN 0.65 and Metrics to macos-13 #4187

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore: Bump E2E RN 0.65 and Metrics to macos-13 #4187

merged 1 commit into from
Oct 17, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Oct 17, 2024 •
edited
Loading

📜 Description

Starting in Nov 24 macos-12 will be removed.

I moved the 0.65 test only to macos-13 because RN 0.65 template is by default not compatible with building on ARM. We would have to change the E2E test to add the fix for ARM to bump to macos-14 and higher.

Metrics are also bumped to macos-13

💡 Motivation and Context

actions/runner-images#10721

💚 How did you test it?

ci

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 455.74 ms 450.24 ms -5.49 ms
Size 17.74 MiB 20.07 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
34aba08 328.10 ms 342.84 ms 14.74 ms
8ae23a7 526.83 ms 513.38 ms -13.45 ms
abb7058 370.27 ms 389.58 ms 19.31 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
62a750b 395.96 ms 423.36 ms 27.41 ms
31fcca2 391.22 ms 414.78 ms 23.56 ms
fe13591 478.92 ms 480.84 ms 1.92 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
5a22220 412.38 ms 447.35 ms 34.97 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms

App size

Revision Plain With Sentry Diff
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
8ae23a7 17.74 MiB 20.07 MiB 2.34 MiB
abb7058 17.73 MiB 19.83 MiB 2.10 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
62a750b 17.73 MiB 19.93 MiB 2.20 MiB
31fcca2 17.73 MiB 19.90 MiB 2.17 MiB
fe13591 17.74 MiB 20.07 MiB 2.34 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
5a22220 17.73 MiB 19.93 MiB 2.20 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB

@github-actions GitHub Actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 382.06 ms 423.24 ms 41.18 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms
5446992+dirty 371.61 ms 390.00 ms 18.39 ms
31fcca2+dirty 366.64 ms 395.78 ms 29.14 ms
457e29f+dirty 591.49 ms 612.96 ms 21.47 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
fe13591+dirty 539.51 ms 597.92 ms 58.40 ms
ad6c299+dirty 336.47 ms 362.89 ms 26.42 ms
148f924+dirty 347.36 ms 389.13 ms 41.77 ms
b1e8712+dirty 322.55 ms 331.84 ms 9.29 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB
5446992+dirty 7.15 MiB 8.12 MiB 999.45 KiB
31fcca2+dirty 7.15 MiB 8.18 MiB 1.03 MiB
457e29f+dirty 7.15 MiB 8.10 MiB 981.29 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
fe13591+dirty 7.15 MiB 8.35 MiB 1.20 MiB
ad6c299+dirty 7.15 MiB 8.04 MiB 912.17 KiB
148f924+dirty 7.15 MiB 8.21 MiB 1.07 MiB
b1e8712+dirty 7.15 MiB 8.04 MiB 912.27 KiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.29 ms 1220.54 ms 1.26 ms
Size 2.36 MiB 3.10 MiB 752.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ac41368+dirty 1226.65 ms 1237.90 ms 11.24 ms
62a750b+dirty 1216.60 ms 1229.14 ms 12.54 ms
baa882f+dirty 1218.00 ms 1227.04 ms 9.04 ms
d361d38+dirty 1246.04 ms 1267.12 ms 21.08 ms
4cc5c27+dirty 1211.45 ms 1214.60 ms 3.16 ms
148f924+dirty 1214.76 ms 1215.73 ms 0.97 ms
8ae23a7+dirty 1230.02 ms 1227.62 ms -2.40 ms
31fcca2+dirty 1209.17 ms 1216.21 ms 7.04 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms

App size

Revision Plain With Sentry Diff
ac41368+dirty 2.36 MiB 3.14 MiB 793.46 KiB
62a750b+dirty 2.36 MiB 2.92 MiB 570.00 KiB
baa882f+dirty 2.36 MiB 3.08 MiB 731.91 KiB
d361d38+dirty 2.36 MiB 2.85 MiB 499.84 KiB
4cc5c27+dirty 2.36 MiB 3.04 MiB 698.52 KiB
148f924+dirty 2.36 MiB 3.04 MiB 696.25 KiB
8ae23a7+dirty 2.36 MiB 3.10 MiB 752.42 KiB
31fcca2+dirty 2.36 MiB 2.90 MiB 552.95 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.45 ms 1233.29 ms -3.16 ms
Size 2.92 MiB 3.66 MiB 757.69 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ac41368+dirty 1226.69 ms 1229.96 ms 3.27 ms
62a750b+dirty 1228.12 ms 1230.53 ms 2.41 ms
baa882f+dirty 1235.48 ms 1229.02 ms -6.46 ms
d361d38+dirty 1272.96 ms 1291.70 ms 18.74 ms
4cc5c27+dirty 1220.43 ms 1215.13 ms -5.30 ms
148f924+dirty 1220.72 ms 1221.30 ms 0.58 ms
8ae23a7+dirty 1233.67 ms 1229.52 ms -4.15 ms
31fcca2+dirty 1222.04 ms 1226.51 ms 4.47 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms

App size

Revision Plain With Sentry Diff
ac41368+dirty 2.92 MiB 3.69 MiB 794.29 KiB
62a750b+dirty 2.92 MiB 3.48 MiB 575.59 KiB
baa882f+dirty 2.92 MiB 3.64 MiB 738.56 KiB
d361d38+dirty 2.92 MiB 3.41 MiB 503.57 KiB
4cc5c27+dirty 2.92 MiB 3.61 MiB 705.47 KiB
148f924+dirty 2.92 MiB 3.60 MiB 701.88 KiB
8ae23a7+dirty 2.92 MiB 3.66 MiB 757.67 KiB
31fcca2+dirty 2.92 MiB 3.46 MiB 557.31 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB

@krystofwoldrich krystofwoldrich marked this pull request as ready for review October 17, 2024 11:54
antonis
antonis approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the CI is clear 🎉

NIT: We could add in the description that the metrics are also bumped to macos-13

philipphofmann
philipphofmann approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krystofwoldrich krystofwoldrich merged commit a2f7367 into main Oct 17, 2024
66 of 67 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/chore/ci-bump-runners branch October 17, 2024 13:13
@krystofwoldrich
Copy link
Member Author

We could add in the description that the metrics are also bumped to macos-13

Yes, make sense.

@krystofwoldrich krystofwoldrich changed the title chore: Bump E2E RN 0.65 to macos-13 chore: Bump E2E RN 0.65 and Metrics to macos-13 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@antonis antonis antonis approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krystofwoldrich @antonis @philipphofmann