Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update scripts/update-javascript.sh to 8.33.1 #4154

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature

Bump to the latest JS SDK.

💚 How did you test it?

ci

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented Oct 7, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.23 ms 1221.07 ms -0.16 ms
Size 2.36 MiB 3.08 MiB 733.61 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1227.09 ms 1226.74 ms -0.35 ms
2d6b4a9+dirty 1219.80 ms 1229.06 ms 9.26 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.36 MiB 3.08 MiB 733.32 KiB
2d6b4a9+dirty 2.36 MiB 3.08 MiB 733.23 KiB

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 405.83 ms 445.32 ms 39.49 ms
Size 7.15 MiB 8.34 MiB 1.19 MiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
2d6b4a9+dirty 460.27 ms 519.66 ms 59.39 ms
f77a902+dirty 478.49 ms 516.40 ms 37.91 ms

App size

Revision Plain With Sentry Diff
2d6b4a9+dirty 7.15 MiB 8.34 MiB 1.19 MiB
f77a902+dirty 7.15 MiB 8.34 MiB 1.19 MiB

Copy link
Contributor

github-actions bot commented Oct 7, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.69 ms 1240.33 ms -3.36 ms
Size 2.92 MiB 3.64 MiB 739.81 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1223.83 ms 1227.98 ms 4.15 ms
2d6b4a9+dirty 1236.09 ms 1234.84 ms -1.24 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.92 MiB 3.64 MiB 739.16 KiB
2d6b4a9+dirty 2.92 MiB 3.64 MiB 739.48 KiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@antonis
Copy link
Collaborator

antonis commented Oct 8, 2024

Considering that the End-to-End Tests / metrics (legacy, android) is flaky in main I'll proceed with merging.

@antonis antonis merged commit a623ec3 into v6 Oct 8, 2024
59 of 60 checks passed
@antonis antonis deleted the kw-bump-js-on-v6 branch October 8, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants