-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: Updates documentation and scripts for the separate macOS sample app #4138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
October 2, 2024 07:59
antonis
changed the title
Misc: Updates documentation and scripts for the separate macOS sample app
misc: Updates documentation and scripts for the separate macOS sample app
Oct 2, 2024
7 tasks
iOS (legacy) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
Base automatically changed from
@krystofwoldrich/split-react-native-and-macos-samples
to
v6
October 2, 2024 08:57
krystofwoldrich
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #4132
📢 Type of change
📜 Description
Updates documentation and scripts for the separate macOS sample app
💡 Motivation and Context
Failure to build the macOS app with the new architecture.
💚 How did you test it?
Run the scripts locally
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps
#skip-changelog