-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(database): Query sources #8670
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments/suggestions but good first draft on this!
Co-authored-by: vivianyentran <[email protected]>
Co-authored-by: vivianyentran <[email protected]>
Co-authored-by: vivianyentran <[email protected]>
@vivianyentran did a round of updates! Mostly just accepting your feedback everywhere, but also added a screenshot. How's it looking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but I'd love more explicit instructions on the threshold configuration
Co-authored-by: vivianyentran <[email protected]>
Co-authored-by: vivianyentran <[email protected]>
Co-authored-by: vivianyentran <[email protected]>
@vivianyentran awesome, thank you! I committed your last two suggestions as-is, the links are correct 👍🏻 Does this PR need any other changes? |
Looks good to me!! |
Documentation for the incoming "Query Sources" feature.
Changes