-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(flags): add platform-specific content and refactor JS integration docs #12172
Merged
aliu39
merged 10 commits into
aliu/ff-integration-doc
from
aliu/flags-platform-specific-configuration
Dec 18, 2024
Merged
ref(flags): add platform-specific content and refactor JS integration docs #12172
aliu39
merged 10 commits into
aliu/ff-integration-doc
from
aliu/flags-platform-specific-configuration
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 10.08kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
billyvg
reviewed
Dec 18, 2024
docs/platforms/javascript/common/configuration/integrations/featureflags.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/configuration/integrations/featureflags.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/configuration/integrations/launchdarkly.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/configuration/integrations/openfeature.mdx
Outdated
Show resolved
Hide resolved
platform-includes/configuration/featureflags/javascript.angular.mdx
Outdated
Show resolved
Hide resolved
platform-includes/configuration/featureflags/javascript.angular.mdx
Outdated
Show resolved
Hide resolved
platform-includes/configuration/featureflags/javascript.angular.mdx
Outdated
Show resolved
Hide resolved
platform-includes/configuration/launchdarkly/javascript.angular.mdx
Outdated
Show resolved
Hide resolved
platform-includes/configuration/launchdarkly/javascript.angular.mdx
Outdated
Show resolved
Hide resolved
aliu39
changed the title
ref(flags): add platform-specific content to JS integration docs
ref(flags): add platform-specific content and refactor JS integration docs
Dec 18, 2024
billyvg
approved these changes
Dec 18, 2024
aliu39
added a commit
that referenced
this pull request
Dec 18, 2024
… JS integration docs (#12151) * feat(flags): document featureFlagsIntegration for custom flag tracking * Lowercase filename and create python file * Del python doc * review comment Co-authored-by: Billy Vong <[email protected]> * keep title consistent w identifier * Rename featureFlags.mdx to featureflags.mdx * Keep sentry/browser in code snippet * Link from js index * Link index from integration doc * Fix invalid Exception syntax * ref(flags): add platform-specific content and refactor JS integration docs (#12172) * ref(flags): add platform-specific content to JS integration docs * featureflags platforms * ld and of platforms * Rm 'Install with npm or yarn' * Label featureflags code as TypeScript * Update info alert and ffs link * Lowercase all code snippet language headers * Rewording from review * Use single quotes in all code snippets * Update provider pkg and docs links * Update links, name 'Generic Support' --------- Co-authored-by: Billy Vong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #12151