Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(js): Update profiling docs #12161

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

docs(js): Update profiling docs #12161

wants to merge 10 commits into from

Conversation

chargome
Copy link
Member

  • restructures profiling docs so meta frameworks can include both browser and node profiling docs
  • removes capacitor from browser profiling as this feature does not seem to be available within webview

closes #11785

@chargome chargome self-assigned this Dec 17, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 0:52am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2024 0:52am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2024 0:52am

@chargome chargome requested a review from JonasBa December 17, 2024 10:47
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 1.28kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.36MB 1.27kB (-0.01%) ⬇️
sentry-docs-client-array-push 9.28MB 6 bytes (-0.0%) ⬇️

coolguyzone
coolguyzone approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the updates 🕺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolguyzone coolguyzone coolguyzone approved these changes

@JonasBa JonasBa Awaiting requested review from JonasBa

Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiling is incorrectly set to browser profiling for several JS SDKs
3 participants
@chargome @coolguyzone @JonasBa