Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding a little comment to SentryViewPhotographer #4655

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

brustolin
Copy link
Contributor

Adding a little comment to SentryViewPhotographer
#skip-changelog

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.588%. Comparing base (bd8b1bf) to head (6110cae).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4655       +/-   ##
=============================================
+ Coverage   90.578%   90.588%   +0.009%     
=============================================
  Files          621       621               
  Lines        71116     71117        +1     
  Branches     25297     25296        -1     
=============================================
+ Hits         64416     64424        +8     
+ Misses        6607      6600        -7     
  Partials        93        93               
Files with missing lines Coverage Δ
Sources/Swift/Tools/SentryViewPhotographer.swift 89.090% <100.000%> (+0.202%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd8b1bf...6110cae. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.94 ms 1245.21 ms 27.27 ms
Size 22.32 KiB 761.25 KiB 738.94 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
99fe600 1226.16 ms 1236.88 ms 10.71 ms
2af280d 1232.31 ms 1249.98 ms 17.67 ms
3cdbaf1 1221.98 ms 1241.77 ms 19.79 ms
277f226 1241.65 ms 1253.74 ms 12.09 ms
1223af7 1212.84 ms 1227.49 ms 14.65 ms
84640bd 1218.29 ms 1240.00 ms 21.71 ms
bd2cb64 1216.14 ms 1241.78 ms 25.64 ms
9454d5d 1230.55 ms 1243.42 ms 12.87 ms
32e64d1 1249.42 ms 1264.76 ms 15.34 ms
371db89 1226.40 ms 1251.54 ms 25.14 ms

App size

Revision Plain With Sentry Diff
99fe600 21.90 KiB 708.13 KiB 686.23 KiB
2af280d 20.76 KiB 435.22 KiB 414.46 KiB
3cdbaf1 22.31 KiB 756.53 KiB 734.22 KiB
277f226 22.84 KiB 401.67 KiB 378.83 KiB
1223af7 21.90 KiB 726.19 KiB 704.29 KiB
84640bd 21.90 KiB 727.72 KiB 705.82 KiB
bd2cb64 22.85 KiB 413.45 KiB 390.60 KiB
9454d5d 20.76 KiB 436.29 KiB 415.53 KiB
32e64d1 20.76 KiB 433.18 KiB 412.42 KiB
371db89 20.76 KiB 427.31 KiB 406.55 KiB

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit 0cb72fd into main Dec 20, 2024
68 of 70 checks passed
@brustolin brustolin deleted the chore/explain-sr branch December 20, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants