Installationoutputs custom resource

[troy0820]

What does this change

Sets up work to be accomplished in #245 which will fully resolve #63.
This sets up the crd and the rbac associated with the new custom resource installation outputs

What issue does it fix

Partially Closes #63

Notes for the reviewer

NOTE: Most of the work is being done in the draft PR from above. The PR was getting to big and decided to break it up.

Checklist

• Did you write tests?
• Did you write documentation?
• Did you make any API changes? Update the corresponding API documentation.

[codecov]

Codecov Report

Merging #246 (125623c) into main (a734060) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   71.75%   71.78%   +0.02%     
==========================================
  Files          13       14       +1     
  Lines        2160     2162       +2     
==========================================
+ Hits         1550     1552       +2     
  Misses        477      477              
  Partials      133      133              

Flag	Coverage Δ
unittests	71.78% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
controllers/installation_controller.go	68.13% <ø> (ø)
api/v1/installationoutput_types.go	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[devigned]

I had one suggestion, but otherwise lgtm!

[devigned]

Would you want to show the outputs with -o wide? Might be nice to add the outputs field with a priority=1.

[troy0820]

That's a good idea. I can update this and resolve when it's pushed.

[troy0820]

I don't believe that I can do this being that the column that would display the outputs would need to be able to handle the "array/slice" of "output". Currently the only supported fields are

integer – non-floating-point numbers
number – floating point numbers
string – strings
boolean – true or false
date – rendered differentially as time since this timestamp

I was thinking a list of strings comma separated would do but wouldn't be able to be surfaced from the kubebuilder directive.

Would the first output be sufficient?

[devigned]

Yeah, I think you'd have to define another field where you format the string you'd want from the outputs, reconcile it each time, and have the print column reference the new field.

I don't think this should hold up this PR. I was just thinking about how it would feel using kubectl.

[troy0820]

If it's worth having for the user experience, the handling of that could be valuable for the user. That would be great to add in the WIP PR. I'm willing to add it there if it makes sense.

 type InstallationOutputStatus struct {
     Phase AgentPhase `json:"phase,omitempty"`
  
     Conditions []metav1.Condition `json:"conditions,omitempty"`
  
     Outputs []Output `json:"outputs,omitempty"`
     
     OutputNames string `json:"outputNames, omitempty"` // <-- new field with priority=1 for wide output.
  }
}


//logic in reconciler 
//Something like this

names := []string{}

for _, name := range inst.Status.Outputs {
    names = append(names, name.Name)
}
outputNames := strings.Join(names, ",")  

// Add to install.Status, etc 
```

[troy0820]

Added

• outputNames as a new field,
• scaffold CRD
• added the printercolumn to be priority 1.

kubectl get installationoutput -A

NAMESPACE   NAME                        PORTER NAME   PORTER NAMESPACE   PHASE
default     installationoutput-sample

kubectl get installationoutput -A -o wide

NAMESPACE   NAME                        PORTER NAME   PORTER NAMESPACE   PHASE   OUTPUT NAMES
default     installationoutput-sample

[troy0820]

More realistic version of what is to be expected:
kubectl get installationoutput -A -o wide

NAMESPACE   NAME                      PORTER NAME               PORTER NAMESPACE   PHASE       OUTPUT NAMES
demo        test-install-1691504789   test-install-1691504789   demo               Succeeded   outAction,outDelay,outExitStatus,outInsecureValue

[devigned]

lgtm!