Convert hierarchy to Fragment

[seadowg]

Work towards #5420
Closes #6303

Why is this the best possible solution? Were any other approaches considered?

I've tried to keep changes to a minimal here with the main goal just being to get the majority of the hierarchy code into a Fragment. There's only two structural changes to highlight really:

1. I ended up rewriting the hierarchy's options menu so that it uses the new MenuProvider API. I felt like this made more sense than rewriting it to use the deprecated Fragment methods.
2. The new Fragment uses a new FormHierarchyViewModel to manage state. This will most likely get merged into FormEntryViewModel, but I think that'll make more sense once form entry has also been moved to a Fragment.

I also added some new tests for code that I found had none.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This shouldn't change any behaviour and the big risk here is that it either does or introduces bugs to flows using the form hierarchy. A general test of using the hierarchy (during form entry and viewing) would be good here.

This also changes the jump/summary icon to the new one!

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
• added a comment above any new strings describing it for translators
• added any new strings with date formatting to DateFormatsTest
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[seadowg]

@getodk/testers marking this ready for testing before review as it'd be good to get a first pass before I clean things up in case there are some fundamental problems here I've missed.

[dbemke]

There used to be 2 icons: to go to the hierarchy view and to go "up" in the hierarchy (the second screenshot). Now there's only one icon and it feels a bit confusing in groups and repeats cause the new icon doesn't suggest where the user is moved after tapping it. Is it expected?

[seadowg]

There used to be 2 icons: to go to the hierarchy view and to go "up" in the hierarchy (the second screenshot). Now there's only one icon and it feels a bit confusing in groups and repeats cause the new icon doesn't suggest where the user is moved after tapping it. Is it expected?

I think this was the intention of #6303, but please correct me if I'm wrong @alyblenkin.

[alyblenkin]

I think this was the intention of #6303, but please correct me if I'm wrong @alyblenkin.

This is a good catch! The goal was just to update the east arrow icon, not the up icon as well. I think the up arrow is still a helpful visual indicator that you're going back up to the table of contents.

[seadowg]

This is a good catch! The goal was just to update the east arrow icon, not the up icon as well. I think the up arrow is still a helpful visual indicator that you're going back up to the table of contents.

That makes sense. Just to be sure though before I unwind anything, the Figma link shows the hierarchy with the list icon in the top right:

I'm guessing that's a mistake?

[alyblenkin]

Sorry I think the group folder icon in the first mockup is a mistake. However, now I'm second guessing myself because we discussed this a while back. @lognaturel correct me if I'm wrong here, but our goal was just update the east arrow, not the up arrow icon as well.

[alyblenkin]

To clarify, I think the list icon would work on it's own if we didn't already have the up arrow, but I think it's a pretty ingrained pattern now. I think the list icon would suggest you go back to the top level given the current pattern where there is more of this concept of moving up or down, but you could also imagine tapping to keep going to the main table of contents. I don't think this is a stronger design choice, rather it could be another option. Not worth considering given we haven't had folks bring up any issues.

[lognaturel]

Feels right to me to leave the up arrow as it is. I think navigating up a level feels relatively clear. I don't think the table of contents icon works well there because it would suggest you go all the way back to the top level.

[alyblenkin]

@seadowg - sorry that you have to unwind things there! I've update the design.

[seadowg]

sorry that you have to unwind things there! I've update the design.

No worries! I just wanted to double check.

[seadowg]

@getodk/testers that should be good to go again!

[dbemke]

Tested with success!

Verified on devices with Android 10, 14

Verified cases:

• the new icon in the hierarchy
• groups and repeats
• the hierarchy view in new forms, drafts, Ready to send, Sent
• the hierarchy view after recovering a savepoint
• moving backwards enabled and disabled
• RTL
• light and dark mode
• don't keep activities enabled and disabled