Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about old entity spec version in form draft update #1317

Closed
wants to merge 2 commits into from

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Dec 3, 2024

Closes getodk/central#816

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite marked this pull request as draft December 3, 2024 20:14
@ktuite
Copy link
Member Author

ktuite commented Dec 3, 2024

Hmm this is actually kind of complicated because of how similar uploading a new draft version and duplicating the published version into a draft are. And it doesn't align with the existing duplicate schema check because the schema could stay the same but the entities version could still differ.

One idea is to not handle this case: If you upload a new version of an existing form that has an old entities xform spec, fine.

@ktuite ktuite closed this Dec 3, 2024
@matthew-white matthew-white deleted the ktuite/entityVersionWarn branch December 7, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn about forms with old version of entity spec when updating existing form
1 participant