Makefile: make explicit that node_modules is dependency of base #1281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
node_modules
to the list of dependencies of thebase
task in the Makefile.node_modules
was already a dependency, becausebase
depends onnode_version
, andnode_version
depends onnode_modules
. However, I think it'd be clearer for us to includenode_modules
in the list explicitly.node_modules
is conceptually distinct fromnode_version
: even if we got rid of thenode_version
check,base
would still need to runnode_modules
. In other words,node_modules
is not just a sub-dependency ofnode_version
.We do something similar with
node_version
and themigrations
task.base
runsmigrations
, andmigrations
runsnode_version
, yet we still includenode_version
in the list explicitly.Before submitting this PR, please make sure you have:
make test
and confirmed all checks still pass OR confirm CircleCI build passes