-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/plugin v2 #284
Feature/plugin v2 #284
Conversation
It's a very impressive and fantastic feature! It seems you have done really hard work, Thank you. Here's some notices.
First, get search result and sort them (I searched After apply filter 'volume = 6' (min 6, max 6), the UI shows that the results are sorted by chapter though they are not actually. This occurred too when I select another manga at the search result. I would propose these, too.
Thanks again for your hard work. |
@Leeingnyo Thanks for reviewing the PR! These are all good points that can help improve the user experience. I will update the PR. |
A new version of the plugin system that supports the following additional features:
mango.settings(key)
. See https://github.com/hkalexling/mango-plugins/wiki/Development-Guideline-v2-(RFC) for details.To target the new v2 API, plugins must put
2
in theapi_version
field in theinfo.json
file. For backward compatability, any plugin without theapi_version
specified will be treated as a v1 plugin.Closes #24. Related getmango/mango-plugins#10 and getmango/mango-plugins#7.