Merge pull request #14 from getlarge/feat-improve-cli-logging

feat: improve CLI loggers
getlarge · Apr 5, 2024 · 9c9e68f · 9c9e68f
2 parents 2843d48 + 075fd52
commit 9c9e68f
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 5 deletions.
diff --git a/packages/keto-cli/src/app/check-permission.command.ts b/packages/keto-cli/src/app/check-permission.command.ts
@@ -31,7 +31,8 @@ export class CheckPermissionCommand extends CommandRunner {
       });
     }
     const { data } = await this.oryPermissionsService.checkPermission(tuple);
-    this.logger.log(`Permission ${data.allowed ? 'granted' : 'denied'}`);
+    this.logger.debug(`Permission ${data.allowed ? 'granted' : 'denied'}`);
+    this.logger.debug(data.allowed);
   }
 
   @Option({

diff --git a/packages/keto-cli/src/index.ts b/packages/keto-cli/src/index.ts
@@ -6,7 +6,9 @@ import { AppModule } from './app/app.module';
 
 async function bootstrap(): Promise<void> {
   await CommandFactory.run(AppModule, {
-    logger: ['log', 'error', 'warn', 'debug', 'verbose'],
+    logger: process.env['DEBUG:KETO_CLI']
+      ? ['log', 'error', 'warn', 'debug']
+      : ['log', 'error', 'warn'],
     enablePositionalOptions: true,
     enablePassThroughOptions: true,
     cliName: '@getlarge/keto-cli',

diff --git a/packages/kratos-cli/src/app/login.command.ts b/packages/kratos-cli/src/app/login.command.ts
@@ -88,9 +88,14 @@ export class LoginCommand extends CommandRunner {
       xSessionToken: sessionToken,
     });
 
-    this.logger.log(
+    this.logger.debug(
       `Logged in with session: ${data.id}, token ${sessionToken}, identity ${data.identity?.id}`
     );
+    this.logger.log({
+      session: data.id,
+      token: sessionToken,
+      identity: data.identity?.id,
+    });
   }
 
   @Option({

diff --git a/packages/kratos-cli/src/app/registration.command.ts b/packages/kratos-cli/src/app/registration.command.ts
@@ -82,9 +82,13 @@ export class RegistrationCommand extends CommandRunner {
       },
     });
 
-    this.logger.log(
+    this.logger.debug(
       `Registered with email: ${email} and identity.id: ${data.identity.id}`
     );
+    this.logger.log({
+      email,
+      identityId: data.identity.id,
+    });
   }
 
   @Option({

diff --git a/packages/kratos-cli/src/index.ts b/packages/kratos-cli/src/index.ts
@@ -6,7 +6,9 @@ import { AppModule } from './app/app.module';
 
 async function bootstrap(): Promise<void> {
   await CommandFactory.run(AppModule, {
-    logger: ['log', 'error', 'warn', 'debug', 'verbose'],
+    logger: process.env['DEBUG:KRATOS_CLI']
+      ? ['log', 'error', 'warn', 'debug']
+      : ['log', 'error', 'warn'],
     enablePositionalOptions: true,
     enablePassThroughOptions: true,
     cliName: '@getlarge/kratos-cli',