Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persist balance display mode #235

Merged
merged 2 commits into from
Dec 27, 2024
Merged

fix: persist balance display mode #235

merged 2 commits into from
Dec 27, 2024

Conversation

im-adithya
Copy link
Member

Fixes #200

Now we store a balanceDisplayMode field in app store and secure-storage

@im-adithya im-adithya requested a review from rolznz December 27, 2024 05:56
pages/Home.tsx Outdated
setBalanceState(BalanceState.FIAT);
} else if (balanceState === BalanceState.FIAT) {
setBalanceState(BalanceState.HIDDEN);
if (balanceDisplayMode === "sats") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: could use a switch here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@im-adithya im-adithya merged commit e297c75 into master Dec 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist Balance Display Mode on Home Screen
2 participants