chore: dismiss all before returning home #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Dec 20, 2024
| if (router.canDismiss()) { | ||
| router.dismissAll(); | ||
| } | ||
| router.navigate("/"); |
There was a problem hiding this comment.
is this navigation even needed if we dismiss all the routes? shouldn't this be the default?
There was a problem hiding this comment.
Won't this also push a route onto the stack, leaving a back button?
There was a problem hiding this comment.
Navigate actually goes to "/" if available (which is actually the only screen in the stack after dismissAll), so it doesn't add a back button
There was a problem hiding this comment.
is this navigation even needed if we dismiss all the routes? shouldn't this be the default?
Makes sense, removed navigation
rolznz
requested changes
Dec 20, 2024
|
Addressed, should be good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the back button in the header, if you cancel/finish setup
Note: for some reason, this cannot be observed in Expo Go but the production build also has this issue.
Screenshots