Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully handle missing permissions #225

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Dec 18, 2024

Fixes #172

@im-adithya
Copy link
Member

Changed Card in wallet settings to reflect the same.

Note: I removed check for transactions as we can later check for that capability when the user requests for notifications.

@rolznz
Copy link
Contributor Author

rolznz commented Dec 20, 2024

Changed Card in wallet settings to reflect the same.

Hmm, now is it looks like it's clickable since the other menu entries are. It should look different from the other menu entries right?

Note: I removed check for transactions as we can later check for that capability when the user requests for notifications.

What you mean here by for transactions? I didn't see it removed? But looks good that you use REQUIRED_CAPABILITIES in that check instead of a hardcoded list

@im-adithya
Copy link
Member

Sorry typo, I removed the check for notifications capability, list_transactions is still there in REQUIRED_CAPABILITIES

And yes, this PR should be kept on hold, Jakub is preparing a design for such error boxes.

@im-adithya im-adithya merged commit 11cf64d into master Dec 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gracefully handle missing permissions / methods
3 participants