This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
3rd PPP #98
Merged
3rd PPP #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzeis
approved these changes
Nov 1, 2022
|
|
||
| - Build a Lightning Full node using LDK and Flutter and open a channel automatically [https://github.com/itchysats/10101/issues/10](https://github.com/itchysats/10101/issues/10). | ||
| - Build out frontend based on the [wireframes](https://www.figma.com/file/zUBJpQ0v8cx6DHivS10OeI/TenTenOneWireFrame). | ||
| - Add a custom output to a Lightning Channel. This will be the base for adding DLCs to a channel. [https://github.com/itchysats/10101/issues/54](https://github.com/itchysats/10101/issues/54) |
There was a problem hiding this comment.
@luckysori are we going to publish the blog post? #14
There was a problem hiding this comment.
As discussed during our demo call, let's publish it during the next iteration 😉
There was a problem hiding this comment.
We can include it in this list then.
luckysori
reviewed
Nov 1, 2022
docs/ppp/iteration_3_01112022.md
Outdated
|
|
||
| - Added an on-chain wallet powered by [BDK](https://github.com/bitcoindevkit/bdk) to our app. We generate a wallet basde on a Bip39 seed phrase [https://github.com/itchysats/10101/issues/68](https://github.com/itchysats/10101/issues/68). | ||
| - Show balance in the wallet. [https://github.com/itchysats/10101/issues/90](https://github.com/itchysats/10101/issues/90). | ||
| - Made progress on our fork of [rust-lightning](https://github.com/itchysats/rust-lightning). While we do not have a full end-to-end test yet we feel confident that it's just a few lines of code away :) |
There was a problem hiding this comment.
I suppose we can now say that we've added a custom output to the commitment transaction!
luckysori
approved these changes
Nov 1, 2022
bonomat
force-pushed
the
docs-lol-ppp-3
branch
from
7cc3c20 to
4b47cf4
Compare
|
bors r+ |
da-kami
approved these changes
Nov 1, 2022
docs/ppp/iteration_3_01112022.md
Outdated
| ### Progress ✅ | ||
|
|
||
| - Added an on-chain wallet powered by [BDK](https://github.com/bitcoindevkit/bdk) to our app. We generate a wallet basde on a Bip39 seed phrase [https://github.com/itchysats/10101/issues/68](https://github.com/itchysats/10101/issues/68). | ||
| - Show balance in the wallet. [https://github.com/itchysats/10101/issues/90](https://github.com/itchysats/10101/issues/90). |
There was a problem hiding this comment.
Here is a screenshot if you want to add it but it does not look like much yet:
Once the navigation bars and FABs (floating action buttons) are in it will look more like an app :)
docs/ppp/iteration_3_01112022.md
Outdated
| ### Plans 📆 | ||
|
|
||
| - Build a Lightning Full node using LDK and Flutter and open a channel automatically [https://github.com/itchysats/10101/issues/10](https://github.com/itchysats/10101/issues/10). | ||
| - Build the trade view based on the [wireframes](https://www.figma.com/file/zUBJpQ0v8cx6DHivS10OeI/TenTenOneWireFrame). |
There was a problem hiding this comment.
Suggested change
| - Build the trade view based on the [wireframes](https://www.figma.com/file/zUBJpQ0v8cx6DHivS10OeI/TenTenOneWireFrame). | |
| - Build the trade view based on the [wireframes](https://www.figma.com/file/zUBJpQ0v8cx6DHivS10OeI/TenTenOneWireFrame) as part of a Flutter app. Flutter allows to us to ship us to multiple devices out of the box. |
docs/ppp/iteration_3_01112022.md
Outdated
| ### Progress ✅ | ||
|
|
||
| - Added an on-chain wallet powered by [BDK](https://github.com/bitcoindevkit/bdk) to our app. We generate a wallet basde on a Bip39 seed phrase [https://github.com/itchysats/10101/issues/68](https://github.com/itchysats/10101/issues/68). | ||
| - Show balance in the wallet. [https://github.com/itchysats/10101/issues/90](https://github.com/itchysats/10101/issues/90). |
There was a problem hiding this comment.
Suggested change
| - Show balance in the wallet. [https://github.com/itchysats/10101/issues/90](https://github.com/itchysats/10101/issues/90). | |
| - Set up Flutter and `flutter-rust-bridge` so we can stick to rust for the beefy parts but have a beautiful cross-platform app based on Flutter. | |
| - Show balance in the wallet screen. [https://github.com/itchysats/10101/issues/90](https://github.com/itchysats/10101/issues/90). | |
| - Work on the Wallet backup screens. [https://github.com/itchysats/10101/pull/81](https://github.com/itchysats/10101/pull/81) | |
| - Work on navigation between Wallet and CFD trading page. [https://github.com/itchysats/10101/issues/90](https://github.com/itchysats/10101/issues/96). |
bors bot
added a commit
that referenced
this pull request
Nov 1, 2022
98: 3rd PPP r=bonomat a=bonomat resolves #55 Please provide more input. I would also add some screenshots from the frontend PRs which are merged already. Co-authored-by: Philipp Hoenisch <[email protected]>
|
bors r- |
|
Canceled. |
Just in time :D |
resolves #55
bonomat
force-pushed
the
docs-lol-ppp-3
branch
from
4b47cf4 to
1bab741
Compare
|
Thanks for the feedback and input everyone :) bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #55
Please provide more input. I would also add some screenshots from the frontend PRs which are merged already.