Skip to content

Commit

Permalink
cleanup options
Browse files Browse the repository at this point in the history
  • Loading branch information
scivision committed May 10, 2024
1 parent 6eefa5f commit dbfda2d
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 11 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ env:
CTEST_NO_TESTS_ACTION: error
CMAKE_BUILD_PARALLEL_LEVEL: 4
CTEST_PARALLEL_LEVEL: 0
CMAKE_INSTALL_PREFIX: ~/libs
CMAKE_PREFIX_PATH: ~/libs

on:
push:
Expand Down Expand Up @@ -73,7 +75,6 @@ jobs:
run: >-
cmake
--preset multi
--install-prefix ${{ runner.temp }}
-DBUILD_SHARED_LIBS:BOOL=${{ matrix.shared }}
- name: Build Debug
Expand All @@ -94,7 +95,6 @@ jobs:
cmake
--preset default
-GNinja
-DCMAKE_PREFIX_PATH:PATH=${{ runner.temp }}
working-directory: example

- name: example build
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/ci_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ env:
CMAKE_BUILD_PARALLEL_LEVEL: 4
CTEST_PARALLEL_LEVEL: 0
CTEST_NO_TESTS_ACTION: error
CMAKE_INSTALL_PREFIX: ~/libs
CMAKE_PREFIX_PATH: ~/libs

on:
push:
Expand All @@ -28,18 +30,15 @@ jobs:
- uses: actions/checkout@v4

- name: Configure HDF5-MPI
run: cmake -B build --install-prefix ${{ runner.temp }}
run: cmake -B build
working-directory: scripts

- name: Build/install HDF5
run: cmake --build build
working-directory: scripts

- name: configure h5fortran
run: >-
cmake --preset default
--install-prefix ${{ runner.temp }}
-DCMAKE_PREFIX_PATH=${{ runner.temp }}
run: cmake --preset default

- name: build h5fortran
run: cmake --build --preset default
Expand All @@ -51,7 +50,7 @@ jobs:
run: cmake --install build

- name: configure examples
run: cmake --preset default -DCMAKE_PREFIX_PATH:PATH=${{ runner.temp }}
run: cmake --preset default
working-directory: example

- name: build Examples
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.20...3.30)
cmake_minimum_required(VERSION 3.21...3.30)

if(CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR)
message(FATAL_ERROR "please use out-of-source build
Expand Down
1 change: 0 additions & 1 deletion cmake/ExtProj.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ TEST_COMMAND ""
CMAKE_ARGS ${cmake_args}
DEPENDS ${depends}
BUILD_BYPRODUCTS ${byproducts}
INACTIVITY_TIMEOUT 60
CONFIGURE_HANDLED_BY_BUILD true
USES_TERMINAL_DOWNLOAD true
USES_TERMINAL_UPDATE true
Expand Down
2 changes: 1 addition & 1 deletion cmake/hdf5.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ set(hdf5_cmake_args
-DHDF5_BUILD_FORTRAN:BOOL=true
-DHDF5_BUILD_CPP_LIB:BOOL=false
-DHDF5_BUILD_EXAMPLES:BOOL=false
-DHDF5_BUILD_TOOLS:BOOL=$<BOOL:${hdf5_parallel}>
-DHDF5_BUILD_TOOLS:BOOL=true
-DHDF5_ENABLE_PARALLEL:BOOL=$<BOOL:${hdf5_parallel}>
)
# https://github.com/HDFGroup/hdf5/issues/818 for broken ph5diff in HDF5_BUILD_TOOLS
Expand Down

0 comments on commit dbfda2d

Please sign in to comment.